diff --git a/django_prometheus/cache/backends/django_memcached_consul.py b/django_prometheus/cache/backends/django_memcached_consul.py index 48c5034d..6dca5cb0 100644 --- a/django_prometheus/cache/backends/django_memcached_consul.py +++ b/django_prometheus/cache/backends/django_memcached_consul.py @@ -15,6 +15,7 @@ def get(self, key, default=None, version=None): cached = super().get(key, default=None, version=version) if cached is not None: django_cache_hits_total.labels(backend="django_memcached_consul").inc() - else: - django_cache_misses_total.labels(backend="django_memcached_consul").inc() - return cached or default + return cached + + django_cache_misses_total.labels(backend="django_memcached_consul").inc() + return default diff --git a/django_prometheus/cache/backends/filebased.py b/django_prometheus/cache/backends/filebased.py index dced9015..80c6565c 100644 --- a/django_prometheus/cache/backends/filebased.py +++ b/django_prometheus/cache/backends/filebased.py @@ -15,6 +15,7 @@ def get(self, key, default=None, version=None): cached = super().get(key, default=None, version=version) if cached is not None: django_cache_hits_total.labels(backend="filebased").inc() - else: - django_cache_misses_total.labels(backend="filebased").inc() - return cached or default + return cached + + django_cache_misses_total.labels(backend="filebased").inc() + return default diff --git a/django_prometheus/cache/backends/locmem.py b/django_prometheus/cache/backends/locmem.py index 1138f84c..e30accf6 100644 --- a/django_prometheus/cache/backends/locmem.py +++ b/django_prometheus/cache/backends/locmem.py @@ -15,6 +15,7 @@ def get(self, key, default=None, version=None): cached = super().get(key, default=None, version=version) if cached is not None: django_cache_hits_total.labels(backend="locmem").inc() - else: - django_cache_misses_total.labels(backend="locmem").inc() - return cached or default + return cached + + django_cache_misses_total.labels(backend="locmem").inc() + return default