Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Non-CSV Files Uploaded Without Error Message or Validation #2112

Open
1 task done
MiriSafra opened this issue Sep 30, 2024 · 1 comment
Open
1 task done

[BUG] Non-CSV Files Uploaded Without Error Message or Validation #2112

MiriSafra opened this issue Sep 30, 2024 · 1 comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@MiriSafra
Copy link
Contributor

MiriSafra commented Sep 30, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Konveyor version

latest

Priority

Undefined

Current Behavior

When uploading a file that is not in CSV format, the file is accepted and displayed in the file list without triggering any error. However, when attempting to drag and drop the non-CSV file, the file is not uploaded, and an error message correctly appears, stating that only CSV files are supported.

Expected Behavior

The application should validate the file format during both standard uploads and drag-and-drop actions, ensuring that non-CSV files are rejected immediately with a corresponding error message.

How Reproducible

Always (Default)

Steps To Reproduce

  1. Navigate to the main screen of the Application Inventory.
  2. Click on the general kebab menu (not the individual one).
    Image
  3. A dialog for file upload will appear.
    Image
  4. Click the Browse button and select a file that is not in CSV format (do not drag the file).
    Then, click OK (When the file selection window opens, change the file type filter to "All Files" to allow the selection of non-CSV files).
    Image
  5. After selecting the file, click the Import button.
  6. You will see that the file is uploaded successfully without any error.
  7. Click the Manage Import button, also located in the general kebab menu, where you can confirm that the non-CSV file has been successfully imported.
    Image

Environment

  • OS: Fedora 40
  • Node: 20.17.0
  • npm: 10.8.2

Anything else?

No response

@MiriSafra MiriSafra added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 30, 2024
@MiriSafra MiriSafra changed the title [BUG] Non-CSV Files Uploaded Without Error Message or Validation [BUG] <Non-CSV Files Uploaded Without Error Message or Validation> Sep 30, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@MiriSafra MiriSafra changed the title [BUG] <Non-CSV Files Uploaded Without Error Message or Validation> [BUG] Non-CSV Files Uploaded Without Error Message or Validation Sep 30, 2024
@konveyor-ci-bot konveyor-ci-bot bot added the needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Status: 🆕 New
Development

No branches or pull requests

1 participant