Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Opentype.js and specimen-tools dependency out #153

Open
kontur opened this issue Mar 18, 2019 · 1 comment
Open

Refactor Opentype.js and specimen-tools dependency out #153

kontur opened this issue Mar 18, 2019 · 1 comment
Labels
enhancement help wanted refactor code and database refactoring
Milestone

Comments

@kontur
Copy link
Owner

kontur commented Mar 18, 2019

Probably the biggest single refactor issue in the plugin lifetime so far.

The reliance on Opentype.js and specimen-tools is a huge performance impact (150kb), fonts loaded as sometimes not-cached AJAX requests. Furthermore, many aspects of specimen-tools that rely on the automatic Opentype.js font extraction cause problems or require Fontsampler specific overwrites where browser limitations or (admin) user input (settings, font names, font files) is not ideal. The main feature that cannot be replicated without Opentype.js is the automatic Opentype support, but that, too, might be nicer to implement as a feature where specific Opentype features are excplicitly enabled on a per-font or per-fontsampler basis.

At that same time this could facilitate a refactor of the Fontsampler javascript to exclude also the jQuery dependency to make the codebase wider applicable for standalone projects.

@kontur kontur added enhancement help wanted refactor code and database refactoring labels Mar 18, 2019
@kontur kontur changed the title Refactor Opentype.js and speciment-tools dependency out Refactor Opentype.js and specimen-tools dependency out Mar 18, 2019
@kontur kontur added this to the JS refactor milestone Mar 18, 2019
@kontur
Copy link
Owner Author

kontur commented Feb 7, 2020

Work on this is started in the fontsampler-js branch, but this requires still a whole bunch of refinement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted refactor code and database refactoring
Projects
None yet
Development

No branches or pull requests

1 participant