Distributed Caching - V15.0.0-alpha3

[johnhydemtm365]

Brief bug description

Error deserializing rich text content when using distributed caching
JsonSerializationException: Cannot preserve reference to array or readonly list, or list created from a non-default constructor: Kentico.Kontent.Delivery.ContentItems.RichText.RichTextContent. Path 'Item.Articles.$values[0].BodyCopy.$values'.

This happens on both my current project and also the Dancing Goat project when using 15.0.0-alpha3 of the delivery client

Kentico.Kontent.Delivery 15.0.0-alpha3
Kentico.Kontent.Delivery.Caching 15.0.0-alpha3
Kentico.Kontent.Delivery.Abstractions 15.0.0-alpha3

What went wrong?

Repro steps

Download dancing goat project, configure distributed caching
Set the caching to 30 seconds
Load the site
Refresh the page immediately

Expected behavior

Page refreshes using the cached version

Additional context

Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateList(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, object existingValue, string id)
Newtonsoft.Json.Serialization.JsonSerializerInternalReader.ReadMetadataProperties(JsonReader reader, ref Type objectType, ref JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, object existingValue, out object newValue, out string id)
Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateObject(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, object existingValue)
Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateValueInternal(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, object existingValue)
Newtonsoft.Json.Serialization.JsonSerializerInternalReader.SetPropertyValue(JsonProperty property, JsonConverter propertyConverter, JsonContainerContract containerContract, JsonProperty containerProperty, JsonReader reader, object target)
Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateObject(object newObject, JsonReader reader, JsonObjectContract contract, JsonProperty member, string id)
Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateObject(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, object existingValue)
Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateValueInternal(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, object existingValue)
Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateList(IList list, JsonReader reader, JsonArrayContract contract, JsonProperty containerProperty, string id)
Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateList(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, object existingValue, string id)
Newtonsoft.Json.Serialization.JsonSerializerInternalReader.ReadMetadataProperties(JsonReader reader, ref Type objectType, ref JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, object existingValue, out object newValue, out string id)
Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateObject(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, object existingValue)
Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateValueInternal(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, object existingValue)
Newtonsoft.Json.Serialization.JsonSerializerInternalReader.SetPropertyValue(JsonProperty property, JsonConverter propertyConverter, JsonContainerContract containerContract, JsonProperty containerProperty, JsonReader reader, object target)
Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateObject(object newObject, JsonReader reader, JsonObjectContract contract, JsonProperty member, string id)
Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateObject(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, object existingValue)
Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateValueInternal(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, object existingValue)
Newtonsoft.Json.Serialization.JsonSerializerInternalReader.ResolvePropertyAndCreatorValues(JsonObjectContract contract, JsonProperty containerProperty, JsonReader reader, Type objectType)
Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateObjectUsingCreatorWithParameters(JsonReader reader, JsonObjectContract contract, JsonProperty containerProperty, ObjectConstructor creator, string id)
Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateNewObject(JsonReader reader, JsonObjectContract objectContract, JsonProperty containerMember, JsonProperty containerProperty, string id, out bool createdFromNonDefaultCreator)
Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateObject(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, object existingValue)
Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateValueInternal(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, object existingValue)
Newtonsoft.Json.Serialization.JsonSerializerInternalReader.Deserialize(JsonReader reader, Type objectType, bool checkAdditionalContent)
Newtonsoft.Json.JsonSerializer.DeserializeInternal(JsonReader reader, Type objectType)
Newtonsoft.Json.JsonSerializer.Deserialize(JsonReader reader, Type objectType)
Newtonsoft.Json.JsonSerializer.Deserialize(JsonReader reader)
Kentico.Kontent.Delivery.Caching.Extensions.SerializationExtensions.FromBson(byte[] byteArray)
Kentico.Kontent.Delivery.Caching.DistributedCacheManager.TryGetAsync(string key)
Kentico.Kontent.Delivery.Caching.DistributedCacheManager.GetOrAddAsync(string key, Func<Task> valueFactory, Func<T, bool> shouldCache, Func<T, IEnumerable> dependenciesFactory)
Kentico.Kontent.Delivery.Caching.DeliveryClientCache.GetItemAsync(string codename, IEnumerable parameters)
DancingGoat.Controllers.HomeController.Index() in HomeController.cs

 var response = await _client.GetItemAsync<Home>("home", new LanguageParameter(Language), new DepthParameter(1));

[petrsvihlik]

I was able to reproduce it.

So far, I can see that this scenario is not covered with tests because the tests use string-based rich-text resolution.

https://github.com/Kentico/kontent-delivery-sdk-net/blob/c136595e678d65673e9dc1834ae063fef0f2a8d7/Kentico.Kontent.Delivery.Caching.Tests/ContentTypes/Article.Generated.cs#L38

So first, we need to replicate the error with a test and then fix it.

My wild guess is that classes such as RichTextContent, and implementations of IRichTextBlock should be enriched with [JsonConstructor]... let's see

[petrsvihlik]

BTW - I hope we'll solve the dichotomy of rich text rendering once and for all in the v16 milestone. Here's the proposal: #259

[petrsvihlik]

repro steps: https://github.com/Kentico/kontent-sample-app-net/compare/RTE-problem

[petrsvihlik]

https://github.com/Kentico/kontent-delivery-sdk-net/releases/tag/15.0.0-alpha4

seems to be working.

thanks for testing the distributed caching!

[johnhydemtm365]

Good morning, appreciate you fixing so quickly. On initial test it seems to be working okay, however on updating your dancing goat sample it broke it.... The Blocks Property of Type IRichTextContent has been removed...? not sure how relevant this is...though?? Thanks John

…

On Sun, 7 Feb 2021 at 22:42, Petr Švihlík ***@***.***> wrote: https://github.com/Kentico/kontent-delivery-sdk-net/releases/tag/15.0.0-alpha4 seems to be working. thanks for testing the distributed caching! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#265 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AH2XYN6Z4JVT6IMUGW6XXXTS54JN3ANCNFSM4XE7HBCQ> .

-- *John Hyde* Technical Operations Manager *T:* +44 (0) 2380 215 399 | *W:* themtmagency.com <https://themtmagency.com/?utm_source=mtm-email-footer> ------------------------------ Facebook <https://www.facebook.com/TheMTMAgency/> | Linkedin <https://www.linkedin.com/company/mtmagency/> | Twitter <https://twitter.com/themtmagency?lang=en> *The MTM Agency* – Saxon House, Saxon Wharf, Lower York Street Southampton, SO14 5QF

[petrsvihlik]

Yes, there was a breaking change to make the code simpler. Please refer to: https://github.com/Kentico/kontent-sample-app-net/compare/RTE-problem

The Blocks property was just a wrapper around an IEnumerable aspect of the IRichTextContent itself. You can safely remove the Blocks property and use the object itself.

[johnhydemtm365]

Awesome did that and it all works anyway :-) Will get onto deeper cach testing now. Thanks John

…

On Mon, 8 Feb 2021 at 08:47, Petr Švihlík ***@***.***> wrote: Yes, there was a breaking change to make the code simpler. Please refer to: https://github.com/Kentico/kontent-sample-app-net/compare/RTE-problem The Blocks property was just a wrapper around an IEnumerable aspect of the IRichTextContent itself. You can safely remove the Blocks property and use the object itself. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#265 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AH2XYN4RM376JPLSA6QBXNTS56QLDANCNFSM4XE7HBCQ> .

-- *John Hyde* Technical Operations Manager *T:* +44 (0) 2380 215 399 | *W:* themtmagency.com <https://themtmagency.com/?utm_source=mtm-email-footer> ------------------------------ Facebook <https://www.facebook.com/TheMTMAgency/> | Linkedin <https://www.linkedin.com/company/mtmagency/> | Twitter <https://twitter.com/themtmagency?lang=en> *The MTM Agency* – Saxon House, Saxon Wharf, Lower York Street Southampton, SO14 5QF