From 8228dca7e23ce812399a3c87a98f0da87d6dd262 Mon Sep 17 00:00:00 2001
From: Cesar Filho <53096417+6za@users.noreply.github.com>
Date: Tue, 4 Oct 2022 09:44:12 -0300
Subject: [PATCH] Fix docker dev image (#494)

* Making dev image more safe

Dev image was bringing too much stuff to the image including logs

* Add ldflags

* update ignore rules
---
 .dockerignore        | 23 +++++++++++++++++++++++
 .gitignore           |  1 +
 build/dev/Dockerfile |  5 +++--
 3 files changed, 27 insertions(+), 2 deletions(-)
 create mode 100644 .dockerignore

diff --git a/.dockerignore b/.dockerignore
new file mode 100644
index 000000000..589fb5b02
--- /dev/null
+++ b/.dockerignore
@@ -0,0 +1,23 @@
+*.env
+node_modules
+.terraform
+.gitlab-bot-access-token
+.gitlab-runner-registration-token
+.vscode
+terraform-ssh-key
+terraform-ssh-key.pub
+kubeconfig_*
+*/cypress/screenshots/
+*/cypress/videos/
+dist/
+**/.DS_Store
+/git
+bin
+.vscode/settings.json
+logs/
+/tmp
+lint_log.txt
+credentials
+.idea
+kubefirst
+.git
diff --git a/.gitignore b/.gitignore
index 41c630fc9..41e862599 100644
--- a/.gitignore
+++ b/.gitignore
@@ -19,3 +19,4 @@ logs/
 lint_log.txt
 credentials
 .idea
+kubefirst
diff --git a/build/dev/Dockerfile b/build/dev/Dockerfile
index 629e9661e..15d4fbd72 100644
--- a/build/dev/Dockerfile
+++ b/build/dev/Dockerfile
@@ -1,6 +1,7 @@
 FROM --platform=linux/amd64 golang:1.18
 
 WORKDIR /opt/kubefirst-install
+ARG KUBEFIRST_VERSION=1.9.3
 
 RUN apt-get update && \
     apt-get install -y unzip curl jq vim unzip less \
@@ -43,8 +44,8 @@ WORKDIR /home/developer/kubefirst
 COPY --chown=developer:developer . .
 
 # download dependencies and prepare fresh installation
-RUN go mod download &&  \
-    go build
+RUN go mod download
+RUN go build -ldflags="-X github.com/kubefirst/kubefirst/configs.K1Version=${KUBEFIRST_VERSION}" .
 
 USER root
 RUN  mv ./kubefirst /usr/local/bin/ && chmod 777 /usr/local/bin/kubefirst