Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using multiple of the same sections with different sessionIds shows incorrect content #21

Open
willcode4food opened this issue Nov 22, 2022 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@willcode4food
Copy link
Contributor

Hi! Thank you so much for the theme. I haven't made a gatsby site in a while and the theming feature allows for a quick turnaround. I am having one issue however. I am using the AboutSection with multiple markdown files with unique filenames and section ids. However sometimes the pages with the AboutSection renders the incorrect piece of content. For example I have a file structure in the content folder like this
image

But the AboutSection component with a sectionId="safety" renders the about.md content. If I clear the cache it will sometimes render the correct content. This happens locally and on Netlify. Any help would be much appreciated. Thanks in advance.

@willcode4food willcode4food changed the title Using multiple of the same sections with the same sessionId shows incorrect content Using multiple of the same sections with different sessionIds shows incorrect content Nov 22, 2022
@willcode4food
Copy link
Contributor Author

Looking through the code now, it appears there's no filtering on sectionId. I guess I made an incorrect assumption that the sectionId would provide this type of behavior. This issue should really be a feature request.

@konstantinmuenster
Copy link
Owner

Hi @willcode4food and thanks for opening this issue! This could very well be the case - the use-case of adding the same section several times on a single page isn't 100% thought through at the moment 😄 I will take a look as soon as I can 🤞

@konstantinmuenster konstantinmuenster self-assigned this Nov 23, 2022
@konstantinmuenster konstantinmuenster added the bug Something isn't working label Nov 23, 2022
@enricoDec
Copy link

Hi @willcode4food and thanks for opening this issue! This could very well be the case - the use-case of adding the same section several times on a single page isn't 100% thought through at the moment 😄 I will take a look as soon as I can 🤞

Actually run into the same problem, I tried using multiple AboutSections to separate Interests into different categories. Would be a nice addition in my opinion. Anyway, really cool project keep it up :)

@rolas978
Copy link

rolas978 commented Sep 1, 2023

Hello!
I have the same issue as well.
has there been any updates since @enricoDec posted?
Thank you @konstantinmuenster for the amazing project!

@konstantinmuenster
Copy link
Owner

There hasn't been any change unfortunately. If someone wants to pick up this issue, I would love to have a PR for it 🙌

@diiigle
Copy link

diiigle commented Oct 25, 2023

Taking this on (at least for the Projects section) and will deliver a PR within the next days.

diiigle added a commit to diiigle/gatsby-theme-portfolio-minimal that referenced this issue Oct 26, 2023
diiigle added a commit to diiigle/gatsby-theme-portfolio-minimal that referenced this issue Oct 26, 2023
diiigle added a commit to diiigle/gatsby-theme-portfolio-minimal that referenced this issue Oct 30, 2023
diiigle added a commit to diiigle/gatsby-theme-portfolio-minimal that referenced this issue Oct 30, 2023
diiigle added a commit to diiigle/gatsby-theme-portfolio-minimal that referenced this issue Oct 30, 2023
diiigle added a commit to diiigle/gatsby-theme-portfolio-minimal that referenced this issue Oct 30, 2023
diiigle added a commit to diiigle/gatsby-theme-portfolio-minimal that referenced this issue Oct 30, 2023
diiigle added a commit to diiigle/gatsby-theme-portfolio-minimal that referenced this issue Oct 30, 2023
diiigle added a commit to diiigle/gatsby-theme-portfolio-minimal that referenced this issue Oct 30, 2023
@diiigle
Copy link

diiigle commented Oct 30, 2023

The feature is ready for review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants