From 481da51e48c3c149bd9cf65b3012171bf9fdc814 Mon Sep 17 00:00:00 2001 From: Tyler Reddy Date: Thu, 29 Dec 2022 12:10:00 -0700 Subject: [PATCH] ENH: add bitwise_and * draft the `bitwise_and` ufunc and turn a subset of its array API standard tests on in CI (this implementation does match the standard, but we don't have "in-place bitwise_and" yet (`__iand__` seems tricky to implement with pykokkos for some reason) * the array API standard testing is quite thorough for this binary ufunc so it was necessary to: - expand the `pykokkos-base` CI builds to include up to 5 ranks - draft broadcasting and casting infrastructure for binary ufuncs (so that we can handle different shape/type interactions) --- .github/workflows/array_api.yml | 4 +- .github/workflows/main_ci.yml | 2 +- pykokkos/__init__.py | 3 +- pykokkos/interface/views.py | 31 +++ pykokkos/lib/ufunc_workunits.py | 408 ++++++++++++++++++++++++++++++++ pykokkos/lib/ufuncs.py | 98 ++++++++ 6 files changed, 542 insertions(+), 4 deletions(-) diff --git a/.github/workflows/array_api.yml b/.github/workflows/array_api.yml index 2d656c21..bbd9bb5b 100644 --- a/.github/workflows/array_api.yml +++ b/.github/workflows/array_api.yml @@ -30,7 +30,7 @@ jobs: cd /tmp git clone https://github.com/kokkos/pykokkos-base.git cd pykokkos-base - python setup.py install -- -DENABLE_LAYOUTS=ON -DENABLE_MEMORY_TRAITS=OFF + python setup.py install -- -DENABLE_LAYOUTS=ON -DENABLE_MEMORY_TRAITS=OFF -DENABLE_VIEW_RANKS=5 - name: Install pykokkos run: | python -m pip install . @@ -49,4 +49,4 @@ jobs: # for hypothesis-driven test case generation pytest $GITHUB_WORKSPACE/pre_compile_tools/pre_compile_ufuncs.py -s # only run a subset of the conformance tests to get started - pytest array_api_tests/meta/test_broadcasting.py array_api_tests/meta/test_equality_mapping.py array_api_tests/meta/test_signatures.py array_api_tests/meta/test_special_cases.py array_api_tests/test_constants.py array_api_tests/meta/test_utils.py array_api_tests/test_creation_functions.py::test_ones array_api_tests/test_creation_functions.py::test_ones_like array_api_tests/test_data_type_functions.py::test_result_type array_api_tests/test_operators_and_elementwise_functions.py::test_log10 array_api_tests/test_operators_and_elementwise_functions.py::test_sqrt array_api_tests/test_operators_and_elementwise_functions.py::test_isfinite array_api_tests/test_operators_and_elementwise_functions.py::test_log2 array_api_tests/test_operators_and_elementwise_functions.py::test_log1p array_api_tests/test_operators_and_elementwise_functions.py::test_isinf array_api_tests/test_operators_and_elementwise_functions.py::test_log array_api_tests/test_array_object.py::test_scalar_casting array_api_tests/test_operators_and_elementwise_functions.py::test_sign array_api_tests/test_operators_and_elementwise_functions.py::test_square array_api_tests/test_operators_and_elementwise_functions.py::test_cos array_api_tests/test_operators_and_elementwise_functions.py::test_round array_api_tests/test_operators_and_elementwise_functions.py::test_trunc array_api_tests/test_operators_and_elementwise_functions.py::test_ceil array_api_tests/test_operators_and_elementwise_functions.py::test_floor + pytest array_api_tests/meta/test_broadcasting.py array_api_tests/meta/test_equality_mapping.py array_api_tests/meta/test_signatures.py array_api_tests/meta/test_special_cases.py array_api_tests/test_constants.py array_api_tests/meta/test_utils.py array_api_tests/test_creation_functions.py::test_ones array_api_tests/test_creation_functions.py::test_ones_like array_api_tests/test_data_type_functions.py::test_result_type array_api_tests/test_operators_and_elementwise_functions.py::test_log10 array_api_tests/test_operators_and_elementwise_functions.py::test_sqrt array_api_tests/test_operators_and_elementwise_functions.py::test_isfinite array_api_tests/test_operators_and_elementwise_functions.py::test_log2 array_api_tests/test_operators_and_elementwise_functions.py::test_log1p array_api_tests/test_operators_and_elementwise_functions.py::test_isinf array_api_tests/test_operators_and_elementwise_functions.py::test_log array_api_tests/test_array_object.py::test_scalar_casting array_api_tests/test_operators_and_elementwise_functions.py::test_sign array_api_tests/test_operators_and_elementwise_functions.py::test_square array_api_tests/test_operators_and_elementwise_functions.py::test_cos array_api_tests/test_operators_and_elementwise_functions.py::test_round array_api_tests/test_operators_and_elementwise_functions.py::test_trunc array_api_tests/test_operators_and_elementwise_functions.py::test_ceil array_api_tests/test_operators_and_elementwise_functions.py::test_floor "array_api_tests/test_operators_and_elementwise_functions.py::test_bitwise_and[bitwise_and(x1, x2)]" "array_api_tests/test_operators_and_elementwise_functions.py::test_bitwise_and[__and__(x1, x2)]" "array_api_tests/test_operators_and_elementwise_functions.py::test_bitwise_and[__and__(x, s)]" diff --git a/.github/workflows/main_ci.yml b/.github/workflows/main_ci.yml index 000af412..35326b0c 100644 --- a/.github/workflows/main_ci.yml +++ b/.github/workflows/main_ci.yml @@ -30,7 +30,7 @@ jobs: cd /tmp git clone https://github.com/kokkos/pykokkos-base.git cd pykokkos-base - python setup.py install -- -DENABLE_LAYOUTS=ON -DENABLE_MEMORY_TRAITS=OFF + python setup.py install -- -DENABLE_LAYOUTS=ON -DENABLE_MEMORY_TRAITS=OFF -DENABLE_VIEW_RANKS=5 - name: Install pykokkos run: | python -m pip install . diff --git a/pykokkos/__init__.py b/pykokkos/__init__.py index 3b83a079..efe1b4bb 100644 --- a/pykokkos/__init__.py +++ b/pykokkos/__init__.py @@ -61,7 +61,8 @@ round, trunc, ceil, - floor) + floor, + bitwise_and) from pykokkos.lib.info import iinfo, finfo from pykokkos.lib.create import (zeros, ones, diff --git a/pykokkos/interface/views.py b/pykokkos/interface/views.py index 7b169874..a2ff5d95 100644 --- a/pykokkos/interface/views.py +++ b/pykokkos/interface/views.py @@ -392,6 +392,37 @@ def __array__(self, dtype=None): return self.data + def __and__(self, other): + # avoid circular import with scoped import + from pykokkos.lib.ufuncs import bitwise_and + if isinstance(other, View): + return bitwise_and(self, other) + elif isinstance(other, bool): + other_new = pk.View([], dtype=pk.uint8) + other_new[:] = other + return bitwise_and(self, other_new) + elif isinstance(other, int): + if 0 <= other <= 255: + other_dtype = pk.uint8 + elif 0 <= other <= 65535: + other_dtype = pk.uint16 + elif 0 <= other <= 4294967295: + other_dtype = pk.uint32 + elif 0 <= other <= 18446744073709551615: + other_dtype = pk.uint64 + elif -128 <= other <= 127: + other_dtype = pk.int8 + elif -32768 <= other <= 32767: + other_dtype = pk.int16 + elif -2147483648 <= other <= 2147483647: + other_dtype = pk.int32 + elif -9223372036854775808 <= other <= 9223372036854775807: + other_dtype = pk.int64 + other_new = pk.View([], dtype=other_dtype) + other_new[:] = other + return bitwise_and(self, other_new) + + @staticmethod def _get_dtype_name(type_name: str) -> str: """ diff --git a/pykokkos/lib/ufunc_workunits.py b/pykokkos/lib/ufunc_workunits.py index 06f12530..562991b4 100644 --- a/pykokkos/lib/ufunc_workunits.py +++ b/pykokkos/lib/ufunc_workunits.py @@ -1,6 +1,413 @@ import pykokkos as pk +@pk.workunit +def bitwise_and_impl_5d_int8(tid: int, + view1: pk.View5D[pk.int8], + view2: pk.View5D[pk.int8], + out: pk.View5D[pk.int8]): + for i in range(view1.extent(1)): + for j in range(view1.extent(2)): + for k in range(view1.extent(3)): + for l in range(view1.extent(4)): + out[tid][i][j][k][l] = view1[tid][i][j][k][l] & view2[tid][i][j][k][l] + + +@pk.workunit +def bitwise_and_impl_5d_int16(tid: int, + view1: pk.View5D[pk.int16], + view2: pk.View5D[pk.int16], + out: pk.View5D[pk.int16]): + for i in range(view1.extent(1)): + for j in range(view1.extent(2)): + for k in range(view1.extent(3)): + for l in range(view1.extent(4)): + out[tid][i][j][k][l] = view1[tid][i][j][k][l] & view2[tid][i][j][k][l] + + +@pk.workunit +def bitwise_and_impl_5d_int32(tid: int, + view1: pk.View5D[pk.int32], + view2: pk.View5D[pk.int32], + out: pk.View5D[pk.int32]): + for i in range(view1.extent(1)): + for j in range(view1.extent(2)): + for k in range(view1.extent(3)): + for l in range(view1.extent(4)): + out[tid][i][j][k][l] = view1[tid][i][j][k][l] & view2[tid][i][j][k][l] + + +@pk.workunit +def bitwise_and_impl_5d_int64(tid: int, + view1: pk.View5D[pk.int64], + view2: pk.View5D[pk.int64], + out: pk.View5D[pk.int64]): + for i in range(view1.extent(1)): + for j in range(view1.extent(2)): + for k in range(view1.extent(3)): + for l in range(view1.extent(4)): + out[tid][i][j][k][l] = view1[tid][i][j][k][l] & view2[tid][i][j][k][l] + + +@pk.workunit +def bitwise_and_impl_5d_uint8(tid: int, + view1: pk.View5D[pk.uint8], + view2: pk.View5D[pk.uint8], + out: pk.View5D[pk.uint8]): + for i in range(view1.extent(1)): + for j in range(view1.extent(2)): + for k in range(view1.extent(3)): + for l in range(view1.extent(4)): + out[tid][i][j][k][l] = view1[tid][i][j][k][l] & view2[tid][i][j][k][l] + + +@pk.workunit +def bitwise_and_impl_5d_uint16(tid: int, + view1: pk.View5D[pk.uint16], + view2: pk.View5D[pk.uint16], + out: pk.View5D[pk.uint16]): + for i in range(view1.extent(1)): + for j in range(view1.extent(2)): + for k in range(view1.extent(3)): + for l in range(view1.extent(4)): + out[tid][i][j][k][l] = view1[tid][i][j][k][l] & view2[tid][i][j][k][l] + + +@pk.workunit +def bitwise_and_impl_5d_uint32(tid: int, + view1: pk.View5D[pk.uint32], + view2: pk.View5D[pk.uint32], + out: pk.View5D[pk.uint32]): + for i in range(view1.extent(1)): + for j in range(view1.extent(2)): + for k in range(view1.extent(3)): + for l in range(view1.extent(4)): + out[tid][i][j][k][l] = view1[tid][i][j][k][l] & view2[tid][i][j][k][l] + + +@pk.workunit +def bitwise_and_impl_5d_uint64(tid: int, + view1: pk.View5D[pk.uint64], + view2: pk.View5D[pk.uint64], + out: pk.View5D[pk.uint64]): + for i in range(view1.extent(1)): + for j in range(view1.extent(2)): + for k in range(view1.extent(3)): + for l in range(view1.extent(4)): + out[tid][i][j][k][l] = view1[tid][i][j][k][l] & view2[tid][i][j][k][l] + + +@pk.workunit +def bitwise_and_impl_4d_uint8(tid: int, + view1: pk.View4D[pk.uint8], + view2: pk.View4D[pk.uint8], + out: pk.View4D[pk.uint8]): + for i in range(view1.extent(1)): + for j in range(view1.extent(2)): + for k in range(view1.extent(3)): + out[tid][i][j][k] = view1[tid][i][j][k] & view2[tid][i][j][k] + + +@pk.workunit +def bitwise_and_impl_4d_uint16(tid: int, + view1: pk.View4D[pk.uint16], + view2: pk.View4D[pk.uint16], + out: pk.View4D[pk.uint16]): + for i in range(view1.extent(1)): + for j in range(view1.extent(2)): + for k in range(view1.extent(3)): + out[tid][i][j][k] = view1[tid][i][j][k] & view2[tid][i][j][k] + + +@pk.workunit +def bitwise_and_impl_4d_uint32(tid: int, + view1: pk.View4D[pk.uint32], + view2: pk.View4D[pk.uint32], + out: pk.View4D[pk.uint32]): + for i in range(view1.extent(1)): + for j in range(view1.extent(2)): + for k in range(view1.extent(3)): + out[tid][i][j][k] = view1[tid][i][j][k] & view2[tid][i][j][k] + + +@pk.workunit +def bitwise_and_impl_4d_uint64(tid: int, + view1: pk.View4D[pk.uint64], + view2: pk.View4D[pk.uint64], + out: pk.View4D[pk.uint64]): + for i in range(view1.extent(1)): + for j in range(view1.extent(2)): + for k in range(view1.extent(3)): + out[tid][i][j][k] = view1[tid][i][j][k] & view2[tid][i][j][k] + + +@pk.workunit +def bitwise_and_impl_3d_uint8(tid: int, + view1: pk.View3D[pk.uint8], + view2: pk.View3D[pk.uint8], + out: pk.View3D[pk.uint8]): + for i in range(view1.extent(1)): + for j in range(view1.extent(2)): + out[tid][i][j] = view1[tid][i][j] & view2[tid][i][j] + + +@pk.workunit +def bitwise_and_impl_3d_uint16(tid: int, + view1: pk.View3D[pk.uint16], + view2: pk.View3D[pk.uint16], + out: pk.View3D[pk.uint16]): + for i in range(view1.extent(1)): + for j in range(view1.extent(2)): + out[tid][i][j] = view1[tid][i][j] & view2[tid][i][j] + + +@pk.workunit +def bitwise_and_impl_3d_uint32(tid: int, + view1: pk.View3D[pk.uint32], + view2: pk.View3D[pk.uint32], + out: pk.View3D[pk.uint32]): + for i in range(view1.extent(1)): + for j in range(view1.extent(2)): + out[tid][i][j] = view1[tid][i][j] & view2[tid][i][j] + + +@pk.workunit +def bitwise_and_impl_3d_uint64(tid: int, + view1: pk.View3D[pk.uint64], + view2: pk.View3D[pk.uint64], + out: pk.View3D[pk.uint64]): + for i in range(view1.extent(1)): + for j in range(view1.extent(2)): + out[tid][i][j] = view1[tid][i][j] & view2[tid][i][j] + + +@pk.workunit +def bitwise_and_impl_2d_uint8(tid: int, + view1: pk.View2D[pk.uint8], + view2: pk.View2D[pk.uint8], + out: pk.View2D[pk.uint8]): + for i in range(view1.extent(1)): + out[tid][i] = view1[tid][i] & view2[tid][i] + + +@pk.workunit +def bitwise_and_impl_2d_uint16(tid: int, + view1: pk.View2D[pk.uint16], + view2: pk.View2D[pk.uint16], + out: pk.View2D[pk.uint16]): + for i in range(view1.extent(1)): + out[tid][i] = view1[tid][i] & view2[tid][i] + + +@pk.workunit +def bitwise_and_impl_2d_uint32(tid: int, + view1: pk.View2D[pk.uint32], + view2: pk.View2D[pk.uint32], + out: pk.View2D[pk.uint32]): + for i in range(view1.extent(1)): + out[tid][i] = view1[tid][i] & view2[tid][i] + + +@pk.workunit +def bitwise_and_impl_2d_uint64(tid: int, + view1: pk.View2D[pk.uint64], + view2: pk.View2D[pk.uint64], + out: pk.View2D[pk.uint64]): + for i in range(view1.extent(1)): + out[tid][i] = view1[tid][i] & view2[tid][i] + + +@pk.workunit +def bitwise_and_impl_1d_uint8(tid: int, + view1: pk.View1D[pk.uint8], + view2: pk.View1D[pk.uint8], + out: pk.View1D[pk.uint8]): + out[tid] = view1[tid] & view2[tid] + + +@pk.workunit +def bitwise_and_impl_1d_int8(tid: int, + view1: pk.View1D[pk.int8], + view2: pk.View1D[pk.int8], + out: pk.View1D[pk.int8]): + out[tid] = view1[tid] & view2[tid] + + +@pk.workunit +def bitwise_and_impl_1d_int16(tid: int, + view1: pk.View1D[pk.int16], + view2: pk.View1D[pk.int16], + out: pk.View1D[pk.int16]): + out[tid] = view1[tid] & view2[tid] + + +@pk.workunit +def bitwise_and_impl_1d_int32(tid: int, + view1: pk.View1D[pk.int32], + view2: pk.View1D[pk.int32], + out: pk.View1D[pk.int32]): + out[tid] = view1[tid] & view2[tid] + + +@pk.workunit +def bitwise_and_impl_1d_int64(tid: int, + view1: pk.View1D[pk.int64], + view2: pk.View1D[pk.int64], + out: pk.View1D[pk.int64]): + out[tid] = view1[tid] & view2[tid] + + +@pk.workunit +def bitwise_and_impl_1d_uint16(tid: int, + view1: pk.View1D[pk.uint16], + view2: pk.View1D[pk.uint16], + out: pk.View1D[pk.uint16]): + out[tid] = view1[tid] & view2[tid] + + +@pk.workunit +def bitwise_and_impl_1d_uint32(tid: int, + view1: pk.View1D[pk.uint32], + view2: pk.View1D[pk.uint32], + out: pk.View1D[pk.uint32]): + out[tid] = view1[tid] & view2[tid] + + +@pk.workunit +def bitwise_and_impl_1d_uint64(tid: int, + view1: pk.View1D[pk.uint64], + view2: pk.View1D[pk.uint64], + out: pk.View1D[pk.uint64]): + out[tid] = view1[tid] & view2[tid] + + +@pk.workunit +def bitwise_and_impl_1d_int64(tid: int, + view1: pk.View1D[pk.int64], + view2: pk.View1D[pk.int64], + out: pk.View1D[pk.int64]): + out[tid] = view1[tid] & view2[tid] + +@pk.workunit +def bitwise_and_impl_2d_int8(tid: int, + view1: pk.View2D[pk.int8], + view2: pk.View2D[pk.int8], + out: pk.View2D[pk.int8]): + for i in range(view1.extent(1)): + out[tid][i] = view1[tid][i] & view2[tid][i] + + +@pk.workunit +def bitwise_and_impl_2d_int16(tid: int, + view1: pk.View2D[pk.int16], + view2: pk.View2D[pk.int16], + out: pk.View2D[pk.int16]): + for i in range(view1.extent(1)): + out[tid][i] = view1[tid][i] & view2[tid][i] + + +@pk.workunit +def bitwise_and_impl_2d_int32(tid: int, + view1: pk.View2D[pk.int32], + view2: pk.View2D[pk.int32], + out: pk.View2D[pk.int32]): + for i in range(view1.extent(1)): + out[tid][i] = view1[tid][i] & view2[tid][i] + + +@pk.workunit +def bitwise_and_impl_2d_int64(tid: int, + view1: pk.View2D[pk.int64], + view2: pk.View2D[pk.int64], + out: pk.View2D[pk.int64]): + for i in range(view1.extent(1)): + out[tid][i] = view1[tid][i] & view2[tid][i] + + +@pk.workunit +def bitwise_and_impl_3d_int8(tid: int, + view1: pk.View3D[pk.int8], + view2: pk.View3D[pk.int8], + out: pk.View3D[pk.int8]): + for i in range(view1.extent(1)): + for j in range(view1.extent(2)): + out[tid][i][j] = view1[tid][i][j] & view2[tid][i][j] + + +@pk.workunit +def bitwise_and_impl_3d_int16(tid: int, + view1: pk.View3D[pk.int16], + view2: pk.View3D[pk.int16], + out: pk.View3D[pk.int16]): + for i in range(view1.extent(1)): + for j in range(view1.extent(2)): + out[tid][i][j] = view1[tid][i][j] & view2[tid][i][j] + + +@pk.workunit +def bitwise_and_impl_3d_int32(tid: int, + view1: pk.View3D[pk.int32], + view2: pk.View3D[pk.int32], + out: pk.View3D[pk.int32]): + for i in range(view1.extent(1)): + for j in range(view1.extent(2)): + out[tid][i][j] = view1[tid][i][j] & view2[tid][i][j] + + +@pk.workunit +def bitwise_and_impl_3d_int64(tid: int, + view1: pk.View3D[pk.int64], + view2: pk.View3D[pk.int64], + out: pk.View3D[pk.int64]): + for i in range(view1.extent(1)): + for j in range(view1.extent(2)): + out[tid][i][j] = view1[tid][i][j] & view2[tid][i][j] + + +@pk.workunit +def bitwise_and_impl_4d_int8(tid: int, + view1: pk.View4D[pk.int8], + view2: pk.View4D[pk.int8], + out: pk.View4D[pk.int8]): + for i in range(view1.extent(1)): + for j in range(view1.extent(2)): + for k in range(view1.extent(3)): + out[tid][i][j][k] = view1[tid][i][j][k] & view2[tid][i][j][k] + + +@pk.workunit +def bitwise_and_impl_4d_int16(tid: int, + view1: pk.View4D[pk.int16], + view2: pk.View4D[pk.int16], + out: pk.View4D[pk.int16]): + for i in range(view1.extent(1)): + for j in range(view1.extent(2)): + for k in range(view1.extent(3)): + out[tid][i][j][k] = view1[tid][i][j][k] & view2[tid][i][j][k] + + +@pk.workunit +def bitwise_and_impl_4d_int32(tid: int, + view1: pk.View4D[pk.int32], + view2: pk.View4D[pk.int32], + out: pk.View4D[pk.int32]): + for i in range(view1.extent(1)): + for j in range(view1.extent(2)): + for k in range(view1.extent(3)): + out[tid][i][j][k] = view1[tid][i][j][k] & view2[tid][i][j][k] + + +@pk.workunit +def bitwise_and_impl_4d_int64(tid: int, + view1: pk.View4D[pk.int64], + view2: pk.View4D[pk.int64], + out: pk.View4D[pk.int64]): + for i in range(view1.extent(1)): + for j in range(view1.extent(2)): + for k in range(view1.extent(3)): + out[tid][i][j][k] = view1[tid][i][j][k] & view2[tid][i][j][k] + + @pk.workunit def floor_impl_1d_double(tid: int, view: pk.View1D[pk.double], out: pk.View1D[pk.double]): out[tid] = floor(view[tid]) @@ -137,6 +544,7 @@ def round_impl_3d_float(tid: int, view: pk.View3D[pk.float], out: pk.View3D[pk.f for j in range(view.extent(2)): out[tid][i][j] = round(view[tid][i][j]) + @pk.workunit def isfinite_impl_1d_double(tid: int, view: pk.View1D[pk.double], out: pk.View1D[pk.uint8]): out[tid] = isfinite(view[tid]) diff --git a/pykokkos/lib/ufuncs.py b/pykokkos/lib/ufuncs.py index 13be86e2..af835049 100644 --- a/pykokkos/lib/ufuncs.py +++ b/pykokkos/lib/ufuncs.py @@ -42,6 +42,50 @@ def _ufunc_kernel_dispatcher(tid, return ret +def _broadcast_views(view1, view2): + # support broadcasting by using the same + # shape matching rules as NumPy + # TODO: determine if this can be done with + # more memory efficiency? + if view1.shape != view2.shape: + new_shape = np.broadcast_shapes(view1.shape, view2.shape) + view1_new = pk.View([*new_shape], dtype=view1.dtype) + view1_new[:] = view1 + view1 = view1_new + view2_new = pk.View([*new_shape], dtype=view2.dtype) + view2_new[:] = view2 + view2 = view2_new + return view1, view2 + + +def _typematch_views(view1, view2): + # very crude casting implementation + # for binary ufuncs + dtype1 = view1.dtype + dtype2 = view2.dtype + dtype_extractor = re.compile(r".*data_types\.(\w+)'>") + res1 = dtype_extractor.match(str(dtype1)) + res2 = dtype_extractor.match(str(dtype2)) + effective_dtype = dtype1 + if res1 is not None and res2 is not None: + res1_dtype_str = res1.group(1) + res2_dtype_str = res2.group(1) + if "int" in res1_dtype_str and "int" in res2_dtype_str: + dtype_1_width = int(res1_dtype_str.split("t")[1]) + dtype_2_width = int(res2_dtype_str.split("t")[1]) + if dtype_1_width >= dtype_2_width: + effective_dtype = dtype1 + view2_new = pk.View([*view2.shape], dtype=effective_dtype) + view2_new[:] = view2 + view2 = view2_new + else: + effective_dtype = dtype2 + view1_new = pk.View([*view1.shape], dtype=effective_dtype) + view1_new[:] = view1 + view1 = view1_new + return view1, view2, effective_dtype + + def reciprocal(view): """ Return the reciprocal of the argument, element-wise. @@ -2679,3 +2723,57 @@ def floor(view): out=out, view=view) return out + + +def bitwise_and(view1, view2): + """ + Computes the bitwise AND of the underlying binary representation of each element + of the respective input views. + + Parameters + ---------- + view1 : pykokkos view + First input view. Should have an integer or boolean data type. + view2 : pykokkos view + Second input view. Should have an integer or boolean data type. + + Returns + ------- + out : pykokkos view + A view containing the element-wise results. + """ + view1, view2 = _broadcast_views(view1, view2) + dtype1 = view1.dtype + dtype2 = view2.dtype + view1, view2, effective_dtype = _typematch_views(view1, view2) + ndims = len(view1.shape) + if ndims > 5: + raise NotImplementedError("bitwise_and() ufunc only supports up to 5D views") + if view1.size == 0: + return view1 + # we can't really handle bool properly + # in workunits + if dtype1 == pk.bool or dtype2 == pk.bool: + ret_bool = True + effective_dtype = pk.uint8 + else: + ret_bool = False + out = pk.View([*view1.shape], dtype=effective_dtype) + if view1.shape == (): + tid = 1 + else: + tid = view1.shape[0] + _ufunc_kernel_dispatcher(tid=tid, + dtype=effective_dtype, + ndims=ndims, + op="bitwise_and", + sub_dispatcher=pk.parallel_for, + out=out, + view1=view1, + view2=view2) + if ret_bool: + new_out = pk.View([*view1.shape], dtype=pk.bool) + new_out[:] = out + return new_out + else: + return out