Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update simple kernel timer to write output to text file #72

Closed
jeffmiles63 opened this issue Nov 12, 2019 · 7 comments
Closed

Update simple kernel timer to write output to text file #72

jeffmiles63 opened this issue Nov 12, 2019 · 7 comments

Comments

@jeffmiles63
Copy link

jeffmiles63 commented Nov 12, 2019

Tool should send output to <hostname>.<process id>.simple_kernel_timer instead of default stdout.

@DavidPoliakoff
Copy link
Contributor

Is this feedback from a user? And are we breaking anybody's current expectations? I'd prefer setting this through an environment variable or build option, with the default remaining unchanged, unless this comes from one of the code teams.

@jeffmiles63
Copy link
Author

So, this issue originated from a discussion in a Kokkos tutorial session. I believe the larger problem is the inconsistency with which the kokkos provided tools report information. Whether it is a build option or additional environment variable is fine, as long as the behavior is consistent across all of the tools.

@crtrott
Copy link
Member

crtrott commented Nov 13, 2019

Actually Jeff mischaracterized a bit. I want the tool to write a text file not a binary file. I think the space savings are just not worth the hassle with the stupid reader. This has been annoying me since we wrote this tool in the first place, and I have not seen a single person who thought it is a brilliant idea that the output file is binary ...

@DavidPoliakoff
Copy link
Contributor

Yeah, having the "simple" tool not write out text is aggravating. I'll think on this a bit. I'm leaning towards the answer:

Short term: update simple-kernel-timer to write a (text) file as the default
Longer term: standards for how tools should output their files, update all existing tools

@jrmadsen
Copy link
Contributor

Longer term: standards for how tools should output their files, update all existing tools

Cereal is a good header-only serialization library to write a JSON file. Also supports XML and binary archives but JSON is just as easy to read as a regular text file and soo easy to postprocess in Python. I say just add cereal as git submodule and do a git submodule update in CMake if it isn't already checked out so it's basically an invisible dependency to the casual observer.

@vlkale
Copy link
Contributor

vlkale commented Feb 1, 2024

I believe PR #235 helps to address this Github Issue.

@vlkale
Copy link
Contributor

vlkale commented May 2, 2024

@jeffmiles63 I am closing this as this #235 should now address this. Please let me know in case there are other questions here.

@vlkale vlkale closed this as completed May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants