-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#define AES_KEYLEN bites with SAMD5 compiler #125
Comments
This would be the sort of thing that namespaces and static constexpr are designed to gracefully sidestep... Rgds Damon |
I don't know maybe. But when I include tiny-AES-c the compiler complains. And I thought changing the compiler delivered includes wouldn't be the right spot... |
Hi @vogt31337 and thanks for your interest in this project. As I usually do, I agree with @DamonHD on this point.
I'll be happy to review a PR with any naming changes you could have in mind :) |
I also agree with @DamonHD, but I don't have enough time / knowledge to implement this. |
Hi,
your tiny AES works flawlessly on an Arduino Feather M4 Express (AVR SAMD5 architecture).
But the #define AES_KEYLEN get's redefined in the include files from the compiler. The SAMD5 has a hardware AES module and defines it's own AES_KEYLEN.
So maybe rename some things in this library?
BR
The text was updated successfully, but these errors were encountered: