Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure conversions of string-constant types properly handle empty strings #189

Open
ublubu opened this issue Dec 27, 2017 · 0 comments
Open

Comments

@ublubu
Copy link
Contributor

ublubu commented Dec 27, 2017

In most (all? nearly all?) cases, it's valid for one of the type-alias-string fields to be empty.
(by type-alias-string, i mean e.g. type PodConditionStatus string)

Make sure the conversion functions don't treat empty strings as a failure case.

Also, be sure to add test cases where fixes are made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant