Skip to content

Commit 7d58d9c

Browse files
committed
fix rendering of cjk characters
1 parent 2db48da commit 7d58d9c

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

kitchen-sink.html

+3
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,9 @@
3737
<div style="text-align: left; padding: 0.5em 1em;">
3838
<a style="color: whitesmoke;" target="_test" rel="noreferer" href="./tool/mode_creator.html">Mode Creator</a>
3939
</div>
40+
<div style="text-align: left; padding: 0.5em 1em;">
41+
<a style="color: whitesmoke;" target="_test" rel="noreferer" href="./tool/perf-test.html">Performance test</a>
42+
</div>
4043
<!--DEVEL-->
4144
</div>
4245
</div>

lib/ace/layer/text.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -331,7 +331,7 @@ var Text = function(parentEl) {
331331
while (m = re.exec(value)) {
332332
var tab = m[1];
333333
var simpleSpace = m[2];
334-
var space = m[3];
334+
var controlCharacter = m[3];
335335
var cjkSpace = m[4];
336336
var cjk = m[5];
337337

@@ -359,10 +359,10 @@ var Text = function(parentEl) {
359359
} else {
360360
valueFragment.appendChild(this.com.createTextNode(simpleSpace, this.element));
361361
}
362-
} else if (space) {
362+
} else if (controlCharacter) {
363363
var span = this.dom.createElement("span");
364364
span.className = "ace_invisible ace_invisible_space ace_invalid";
365-
span.textContent = self.SPACE_CHAR;
365+
span.textContent = lang.stringRepeat(self.SPACE_CHAR, controlCharacter.length);
366366
valueFragment.appendChild(span);
367367
} else if (cjkSpace) {
368368
// U+3000 is both invisible AND full-width, so must be handled uniquely
@@ -378,7 +378,7 @@ var Text = function(parentEl) {
378378
screenColumn += 1;
379379
var span = dom.createElement("span");
380380
span.style.width = (self.config.characterWidth * 2) + "px";
381-
span.className = "ace_invisible ace_invisible_space ace_invalid";
381+
span.className = "ace_cjk";
382382
span.textContent = cjk;
383383
valueFragment.appendChild(span);
384384
}

0 commit comments

Comments
 (0)