Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drag screen #105

Closed

Conversation

mogimogitomato
Copy link

I wanted to move the screen when the mouse is held down and dragged,
so I made it possible to perform screen dragging by detect mousedown + mousemove.

2024-07-11 00 15 28

PS:

Thank you for the nice gem!
I was looking for a way to output column comments on ER diagrams, and I found this gem.
Thanks for the multifunctionality.

@kjcpaas
Copy link

kjcpaas commented Aug 8, 2024

I've started using this gem recently loving it so far!

Would love to see this feature added in as it is very useful.

@k-nasa
Copy link

k-nasa commented Sep 27, 2024

I'm finding this Gem very useful. Thank you! I think this feature is extremely helpful, and I'm looking forward to future additions.

@shifakhan
Copy link

This looks like a useful feature, hope it gets merged soon!

@unchidev
Copy link
Member

@mogimogitomato

Thank you for your PR!
This functionality has been incorporated in PR #138. I'll close this PR for the following reasons 🙏🏿:

  1. The proposed implementation prevents text selection via drag interaction
  2. For mouse-based operations, we wanted to provide it together with zoom functionality

Thank you for contributing to improve the project. Looking forward to your future enhancements!

@unchidev unchidev closed this Dec 28, 2024
@mogimogitomato
Copy link
Author

mogimogitomato commented Dec 28, 2024

@unchidev

I tried v0.6.0, so cool !!! and very useful, I agree with the thoughts you commented on.
Also my code was imperfect (Ex: The use of movement x/y should have been prudent... and so on),
the PR #138 diff was very informative for me.

Thank you for contributing to improve the project. Looking forward to your future enhancements!

Thank you as well! If I come up with something else, I will be happy to make suggestions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants