Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Swap landing not disabling submit button on wrong address #11255

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: Swap landing not disabling submit button on wrong address #11255

wants to merge 5 commits into from

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Dec 16, 2024 •
edited
Loading

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Log

  • fix: AddressChecker.vue emitting isValid when addresss is empty
  • ref: adapt Transfer.vue check if address is empty
  • ref: AddressInput.vue dont show error input if address is empty with address check

Screenshot 📸

  • My fix has changed something on UI;

CleanShot 2024-12-16 at 16 44 22

Valid Address

Wrong network address

Is your address

Add address first

@hassnian
fix(swaps): trader address validation is not reactive
5b9f63e 
- fix: AddressChecker.vue emitting isValid when addresss is ''
- ref: adapt Transfer.vue check if address is empty
- ref: AddressInput.vue dont show error input if address is empty with address check
@hassnian hassnian requested a review from a team as a code owner December 16, 2024 11:54
@hassnian hassnian requested review from preschian and Jarsen136 and removed request for a team December 16, 2024 11:54
@netlify Netlify
Copy link

netlify bot commented Dec 16, 2024 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 5b9f63e
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/676014f27f213d00076f6100
😎 Deploy Preview https://deploy-preview-11255--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Dec 16, 2024 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit d5d3308
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6760e3bd889e770008ce2b15
😎 Deploy Preview https://deploy-preview-11255--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hassnian hassnian marked this pull request as draft December 16, 2024 12:42
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@hassnian hassnian marked this pull request as ready for review December 17, 2024 02:39
@hassnian hassnian added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarsen136 Jarsen136 Jarsen136 approved these changes

@preschian preschian preschian approved these changes

Assignees
No one assigned
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Swap landing not disabling submit button on wrong address
3 participants
@hassnian @preschian @Jarsen136