-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump http lib version #120
base: master
Are you sure you want to change the base?
Conversation
@@ -10,7 +10,7 @@ environment: | |||
|
|||
dependencies: | |||
meta: ^1.6.0 | |||
http: ^0.13.0 | |||
http: ^1.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not make it less restrictive, i.e.
http: ">=0.13.0 <2.0.0"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not make it less restrictive, i.e.
http: ">=0.13.0 <2.0.0"
Cause some other packages use http 1.0.0 already. It means that we need to downgrade all others, in order to work with algolia
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure you understood the version restriction above.
Btw, you can always resort to dependency_overrides
if your requirement for ^1.0.0
is so dire.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest going with http: ">=0.13.0 <2.0.0"
as well. It would greatly ease transition.
See for example the google sign-in package
Please merge as soon as possible. Currently in order not to face issues with version incompatibility, I'll need to use this branch as a patch |
bump |
Would be nice to get this in. |
any update for the merger date? |
In the mantime you can simply do dependency_overrides:
http: ^1.0.0 |
Looking to bump to the 1.0 HTTP lib.