-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Knop Demo Login - Implement standard security practices #44
Comments
Suggest multiple failed logins be able to be managed by a site flag to chose what action to take - delay (minutes) / block (require reset) / redirect during "security action period" Suggest having site setting for time in which failed attempts are detected Consider delay use of / blocking IP after nominated number of failed login attempts from one IP within defined time period (any invalid login / password combination) |
I've incorporated what I understood, but I need a little more clarification. I'm not sure I understand this: redirect during "security action period". Is this where the system has identified and locked out a user from logging in after repeated failed attempts, and then redirects the user to a page where they can no longer attempt a login? If so, then the redirect itself is beyond the scope of Knop, however the lockout could be part of Knop. It would be up to the developer to decide what to do during the lockout period. I have implemented the non-redirecting lockout to clear the lockout after a period of time in some systems, but it relies on the Lasso 8 [event_schedule] tag which is not supported in Lasso 9. Can you also elaborate on "time in which failed attempts are detected"? Do you mean, for example, specific times (9a - 5p) or a duration (15 minutes)? Please let me know if I've missed anything in the revision of the issue description above. Thank you! |
"security action period" is the period during which the ability to log in is inhibited (until expiry of set time or reset, dependent upon implementation). Agreed that the actions to take should reset with the solution and not Knop - just tossing out there things we do at te moment. Agree that "Duration" is a better word than "time" to describe the period within which attempts are evaluated - typically shorter for straight failed logins (e.g. 3 failed attempts within 2 mins) |
Added:
Updated:
Thank you! |
The Knop Demo's Login does not implement the features that Knop provides, and additional basic security features beyond the scope of Knop are left off.
knop_user
supports a fingerprint for authenticated users, but not for anonymous users, so this code could be reused. See:https://github.com/knop-project/knop/blob/master/knop8/source/_ctype/user.inc#L27
HTTPS/SSL probably will not be implemented for the Demo because it makes it hard for newbs to get started. Instead we might offer a flag in the global config to enable SSL with a redirect to a secure login page.
The text was updated successfully, but these errors were encountered: