Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code optimization suggestions #428

Open
noobyu6 opened this issue Jun 3, 2022 · 0 comments
Open

Code optimization suggestions #428

noobyu6 opened this issue Jun 3, 2022 · 0 comments

Comments

@noobyu6
Copy link

noobyu6 commented Jun 3, 2022

Hi,

I find that the private field factory at Line 17 in the file 'disconf/disconf-client/src/main/java/com/baidu/disconf/client/scan/inner/statically/strategy/impl/SpringScanStatic.java' on the master branch is only assigned and used in the method scan. Therefore, this field can be removed from the class, and become a local variable in the method scan. This transformation will normally reduce memory usage and improve readability of your code.

 private DefaultListableBeanFactory factory; // line 17 this field can be replaced by local variable ​  public ScanStaticModel scan(List<String> packNameList) {         // DefaultListableBeanFactory factory = (DefaultListableBeanFactory) context.getAutowireCapableBeanFactory();         factory = (DefaultListableBeanFactory) context.getAutowireCapableBeanFactory();         return null;     }

Besides, there are other fields like this.I sorted them out and put them in the table below.I will be happy if this transformation is helpful.

Location Field
com.baidu.disconf.core.common.zookeeper.ZookeeperMgr curHost
com.baidu.disconf.core.common.zookeeper.ZookeeperMgr curDefaultPrefixString
com.baidu.disconf.client.addons.properties.ReloadablePropertiesFactoryBean applicationContext
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant