Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report_go_test does not fail when there are no tests #2079

Open
chizhg opened this issue May 15, 2020 · 3 comments
Open

report_go_test does not fail when there are no tests #2079

chizhg opened this issue May 15, 2020 · 3 comments
Labels
bug Something isn't working lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@chizhg
Copy link
Member

chizhg commented May 15, 2020

When the test package does not contain any tests, the report_go_test function reports as success the test flow still passes even when there is error.

https://knative.slack.com/archives/CA1DTGZ2N/p1589561963210900 is the discussion on Slack.

@chizhg chizhg added the bug Something isn't working label May 15, 2020
@chaodaiG
Copy link
Contributor

There are two sides of this problem:

  1. There are cases where a test suite crashed and no junit result logged, this is where report_go_test reports a test failure
  2. When there is no go test in a directory, report_go_test still reports it as failed, this is not desired. However, I would argue that it should report failure if someone call go test <dirA> and there is no test in <dirA>

@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen.Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 17, 2020
@chizhg
Copy link
Member Author

chizhg commented Aug 17, 2020

/lifecycle frozen

@knative-prow-robot knative-prow-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

3 participants