diff --git a/Makefile b/Makefile index 6ce46b290..b3f0f0cfe 100644 --- a/Makefile +++ b/Makefile @@ -29,12 +29,13 @@ VERS ?= $(shell git describe --tags --match 'v*') KVER ?= $(shell git describe --tags --match 'knative-*') LDFLAGS := -X knative.dev/func/pkg/app.vers=$(VERS) -X knative.dev/func/pkg/app.kver=$(KVER) -X knative.dev/func/pkg/app.hash=$(HASH) -ifneq ($(FUNC_REPO_REF),) - LDFLAGS += -X knative.dev/func/pkg/pipelines/tekton.FuncRepoRef=$(FUNC_REPO_REF) -endif -ifneq ($(FUNC_REPO_BRANCH_REF),) - LDFLAGS += -X knative.dev/func/pkg/pipelines/tekton.FuncRepoBranchRef=$(FUNC_REPO_BRANCH_REF) -endif + +FUNC_UTILS_IMG ?= ghcr.io/knative/func-utils:latest +LDFLAGS += -X knative.dev/func/pkg/k8s.SocatImage=$(FUNC_UTILS_IMG) +LDFLAGS += -X knative.dev/func/pkg/k8s.TarImage=$(FUNC_UTILS_IMG) +LDFLAGS += -X knative.dev/func/pkg/pipelines/tekton.DeployerImage=$(FUNC_UTILS_IMG) + +GOFLAGS := "-ldflags=$(LDFLAGS)" MAKEFILE_DIR := $(dir $(abspath $(lastword $(MAKEFILE_LIST)))) @@ -62,11 +63,11 @@ build: $(BIN) ## (default) Build binary for current OS .PHONY: $(BIN) $(BIN): generate/zz_filesystem_generated.go - env CGO_ENABLED=0 go build -ldflags "$(LDFLAGS)" ./cmd/$(BIN) + env CGO_ENABLED=0 go build ./cmd/$(BIN) .PHONY: test test: generate/zz_filesystem_generated.go ## Run core unit tests - go test -ldflags "$(LDFLAGS)" -race -cover -coverprofile=coverage.txt ./... + go test -race -cover -coverprofile=coverage.txt ./... .PHONY: check check: $(BIN_GOLANGCI_LINT) ## Check code quality (lint) @@ -195,12 +196,12 @@ templates/certs/ca-certificates.crt: ################### test-integration: ## Run integration tests using an available cluster. - go test -ldflags "$(LDFLAGS)" -tags integration -timeout 30m --coverprofile=coverage.txt ./... -v + go test -tags integration -timeout 30m --coverprofile=coverage.txt ./... -v .PHONY: func-instrumented func-instrumented: ## Func binary that is instrumented for e2e tests - env CGO_ENABLED=1 go build -ldflags "$(LDFLAGS)" -cover -o func ./cmd/$(BIN) + env CGO_ENABLED=1 go build -cover -o func ./cmd/$(BIN) test-e2e: func-instrumented ## Run end-to-end tests using an available cluster. ./test/e2e_extended_tests.sh @@ -220,37 +221,37 @@ cross-platform: darwin-arm64 darwin-amd64 linux-amd64 linux-arm64 linux-ppc64le darwin-arm64: $(BIN_DARWIN_ARM64) ## Build for mac M1 $(BIN_DARWIN_ARM64): generate/zz_filesystem_generated.go - env CGO_ENABLED=0 GOOS=darwin GOARCH=arm64 go build -o $(BIN_DARWIN_ARM64) -trimpath -ldflags "$(LDFLAGS) -w -s" ./cmd/$(BIN) + env CGO_ENABLED=0 GOOS=darwin GOARCH=arm64 go build -o $(BIN_DARWIN_ARM64) -trimpath -w -s" ./cmd/$(BIN) darwin-amd64: $(BIN_DARWIN_AMD64) ## Build for Darwin (macOS) $(BIN_DARWIN_AMD64): generate/zz_filesystem_generated.go - env CGO_ENABLED=0 GOOS=darwin GOARCH=amd64 go build -o $(BIN_DARWIN_AMD64) -trimpath -ldflags "$(LDFLAGS) -w -s" ./cmd/$(BIN) + env CGO_ENABLED=0 GOOS=darwin GOARCH=amd64 go build -o $(BIN_DARWIN_AMD64) -trimpath -w -s" ./cmd/$(BIN) linux-amd64: $(BIN_LINUX_AMD64) ## Build for Linux amd64 $(BIN_LINUX_AMD64): generate/zz_filesystem_generated.go - env CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -o $(BIN_LINUX_AMD64) -trimpath -ldflags "$(LDFLAGS) -w -s" ./cmd/$(BIN) + env CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -o $(BIN_LINUX_AMD64) -trimpath -w -s" ./cmd/$(BIN) linux-arm64: $(BIN_LINUX_ARM64) ## Build for Linux arm64 $(BIN_LINUX_ARM64): generate/zz_filesystem_generated.go - env CGO_ENABLED=0 GOOS=linux GOARCH=arm64 go build -o $(BIN_LINUX_ARM64) -trimpath -ldflags "$(LDFLAGS) -w -s" ./cmd/$(BIN) + env CGO_ENABLED=0 GOOS=linux GOARCH=arm64 go build -o $(BIN_LINUX_ARM64) -trimpath -w -s" ./cmd/$(BIN) linux-ppc64le: $(BIN_LINUX_PPC64LE) ## Build for Linux ppc64le $(BIN_LINUX_PPC64LE): generate/zz_filesystem_generated.go - env CGO_ENABLED=0 GOOS=linux GOARCH=ppc64le go build -o $(BIN_LINUX_PPC64LE) -trimpath -ldflags "$(LDFLAGS) -w -s" ./cmd/$(BIN) + env CGO_ENABLED=0 GOOS=linux GOARCH=ppc64le go build -o $(BIN_LINUX_PPC64LE) -trimpath -w -s" ./cmd/$(BIN) linux-s390x: $(BIN_LINUX_S390X) ## Build for Linux s390x $(BIN_LINUX_S390X): generate/zz_filesystem_generated.go - env CGO_ENABLED=0 GOOS=linux GOARCH=s390x go build -o $(BIN_LINUX_S390X) -trimpath -ldflags "$(LDFLAGS) -w -s" ./cmd/$(BIN) + env CGO_ENABLED=0 GOOS=linux GOARCH=s390x go build -o $(BIN_LINUX_S390X) -trimpath -w -s" ./cmd/$(BIN) windows: $(BIN_WINDOWS) ## Build for Windows $(BIN_WINDOWS): generate/zz_filesystem_generated.go - env CGO_ENABLED=0 GOOS=windows GOARCH=amd64 go build -o $(BIN_WINDOWS) -trimpath -ldflags "$(LDFLAGS) -w -s" ./cmd/$(BIN) + env CGO_ENABLED=0 GOOS=windows GOARCH=amd64 go build -o $(BIN_WINDOWS) -trimpath -w -s" ./cmd/$(BIN) ###################### ##@ Schemas