From 562d64c2b1c06c616383d29d292c0fd385afa68b Mon Sep 17 00:00:00 2001 From: vaidikcode Date: Thu, 23 Jan 2025 18:24:00 +0530 Subject: [PATCH 1/3] constTovar --- pkg/apis/messaging/v1/in_memory_channel_validation.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pkg/apis/messaging/v1/in_memory_channel_validation.go b/pkg/apis/messaging/v1/in_memory_channel_validation.go index 5f7e5f42d76..9efc58ef06e 100644 --- a/pkg/apis/messaging/v1/in_memory_channel_validation.go +++ b/pkg/apis/messaging/v1/in_memory_channel_validation.go @@ -19,6 +19,7 @@ package v1 import ( "context" "fmt" + "knative.dev/pkg/system" "knative.dev/pkg/apis" "knative.dev/pkg/kmp" @@ -26,7 +27,7 @@ import ( "knative.dev/eventing/pkg/apis/eventing" ) -const eventingControllerSAName = "system:serviceaccount:knative-eventing:eventing-controller" +var eventingControllerSAName = fmt.Sprintf("system:serviceaccount:%s:eventing-controller", system.Namespace()) func (imc *InMemoryChannel) Validate(ctx context.Context) *apis.FieldError { errs := imc.Spec.Validate(ctx).ViaField("spec") From ae0df7b04908330d42964331a7a22f2079488453 Mon Sep 17 00:00:00 2001 From: vaidikcode Date: Thu, 23 Jan 2025 19:13:55 +0530 Subject: [PATCH 2/3] fix --- pkg/apis/messaging/v1/in_memory_channel_validation.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/apis/messaging/v1/in_memory_channel_validation.go b/pkg/apis/messaging/v1/in_memory_channel_validation.go index 9efc58ef06e..7f1257f239a 100644 --- a/pkg/apis/messaging/v1/in_memory_channel_validation.go +++ b/pkg/apis/messaging/v1/in_memory_channel_validation.go @@ -19,10 +19,10 @@ package v1 import ( "context" "fmt" - "knative.dev/pkg/system" "knative.dev/pkg/apis" "knative.dev/pkg/kmp" + "knative.dev/pkg/system" "knative.dev/eventing/pkg/apis/eventing" ) From cacbc0cbffc78e59402bc7dff5de799dcf201b68 Mon Sep 17 00:00:00 2001 From: vaidikcode Date: Thu, 23 Jan 2025 19:36:31 +0530 Subject: [PATCH 3/3] fix --- pkg/apis/messaging/v1/in_memory_channel_validation.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/pkg/apis/messaging/v1/in_memory_channel_validation.go b/pkg/apis/messaging/v1/in_memory_channel_validation.go index 7f1257f239a..b6c701c8a97 100644 --- a/pkg/apis/messaging/v1/in_memory_channel_validation.go +++ b/pkg/apis/messaging/v1/in_memory_channel_validation.go @@ -27,7 +27,11 @@ import ( "knative.dev/eventing/pkg/apis/eventing" ) -var eventingControllerSAName = fmt.Sprintf("system:serviceaccount:%s:eventing-controller", system.Namespace()) +var eventingControllerSAName string + +func init() { + eventingControllerSAName = fmt.Sprintf("system:serviceaccount:%s:eventing-controller", system.Namespace()) +} func (imc *InMemoryChannel) Validate(ctx context.Context) *apis.FieldError { errs := imc.Spec.Validate(ctx).ViaField("spec")