Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run all knative-sample images as non-root #14566

Closed
kauana opened this issue Oct 24, 2023 · 13 comments
Closed

Run all knative-sample images as non-root #14566

kauana opened this issue Oct 24, 2023 · 13 comments
Labels
area/build Build topics specifically related to Knative good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Well-understood/specified features, ready for coding. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@kauana
Copy link
Member

kauana commented Oct 24, 2023

/area build
/kind good-first-issue

Context

Related issues: #14029 / #14168

As part of the effort to enable secure-pod-defaults by default, we must ensure that all knative-sample images run as non-root. This will ensure that if we decide to enable this feature, it won't disrupt installations for folks doing demos, tests, talks, etc. (note that once this feature is activated, all images will be mandated to run as non-root)

What

Ensure that all images used as knative samples are running as non-root. Please see Knative Serving code samples for a list of all images currently used as samples.

We should also highlight this change in the release notes. This will keep the community informed and allow us to collect feedback to determine if activating secure-pod-defaults by default is indeed the way to go.
@kauana kauana added the kind/feature Well-understood/specified features, ready for coding. label Oct 24, 2023
@knative-prow knative-prow bot added area/build Build topics specifically related to Knative kind/good-first-issue Denotes an issue ready for a new contributor. labels Oct 24, 2023
@kauana kauana mentioned this issue Oct 24, 2023
Open
@karthikmurali60
Copy link

/assign

@karthikmurali60
Copy link

@kauana I would like to work on this issue. Where can i get started ?

@kauana
Copy link
Member Author

kauana commented Oct 31, 2023 •
edited
Loading

Hello @karthikmurali60, thank you for picking this up! Basically we want to update the knative-sample images from here to run as non-root, so one way is to configure the sample images' Dockerfile (Dockerfile example for helloworld-go) to run as a non-root user.

@prushh
Copy link

prushh commented Nov 8, 2023

Hi everyone, I would like to work on this issue.

Are you still working on it, @karthikmurali60?

@karthikmurali60
Copy link

@prushh yeah i am working on it

@karthikmurali60 karthikmurali60 mentioned this issue Nov 13, 2023
Closed
@karthikmurali60
Copy link

@kauana can you please review the linked PR - knative/docs#5758 ??

@kauana
Copy link
Member Author

kauana commented Nov 15, 2023

Thank you for the PR! I'm looking at it :)

@prushh prushh mentioned this issue Nov 16, 2023
Closed
27 tasks
@dprotaso dprotaso added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. and removed kind/good-first-issue Denotes an issue ready for a new contributor. labels Nov 23, 2023
@prushh prushh mentioned this issue Dec 11, 2023
Closed
24 tasks
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 22, 2024
@ReToCode
Copy link
Member

/remove-lifecycle stale

@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 22, 2024
@aliok
Copy link
Member

aliok commented May 22, 2024

/unassign karthikmurali60

@ayushrakesh
Copy link

@kauana Is this issue still needs some work? I am interested.

@ReToCode
Copy link
Member

ReToCode commented Jul 1, 2024

Yes it does, check out the knative/docs#5794. There are still open tasks to be resolved, but your work could be started from that.

@github-actions GitHub Actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 30, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/build Build topics specifically related to Knative good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Well-understood/specified features, ready for coding. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
7 participants
@dprotaso @aliok @kauana @ReToCode @karthikmurali60 @prushh @ayushrakesh