Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to Eventing Data Plane Contract/SPEC #4943

Open
embano1 opened this issue Apr 27, 2022 · 7 comments
Open

Link to Eventing Data Plane Contract/SPEC #4943

embano1 opened this issue Apr 27, 2022 · 7 comments
Labels
kind/eventing kind/functions priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. triage/accepted Issues which should be fixed (post-triage)

Comments

@embano1
Copy link
Contributor

embano1 commented Apr 27, 2022

Describe the change you'd like to see
Speaking to many function authors (i.e. Knative Service with Eventing), especially newcomers, most of them are not aware of the underlying data plane contract, e.g. used by brokers. This can lead to issues where retry and error behavior by a function (Kservice) is incorrectly assumed/handled.

Examples SPEC says to retry on 404 which is typically not what users expect (404s are usually not retriable and the SPEC bends the rules here IMHO a bit for a particular use case).

Proposal: add a section to the docs describing the impact of the data plane contract to Knative function authors so at least they are aware of the behavior. The only issue is that not all implementations might strictly follow the SPEC, so this should be considered best effort/best practice for now until we are sure that all implementations strictly follow the SPEC.

Additional context
Add any other context or screenshots about the feature request here.

@abrennan89
Copy link
Contributor

@knative-sandbox/func-wg-leads @knative/eventing-wg-leads can ya'll provide some information here about what needs to be documented?

@pierDipi
Copy link
Member

@abrennan89 abrennan89 added priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. and removed triage/needs-eng-input Engineering input is requested status/blocked labels Oct 10, 2022
@github-actions
Copy link

github-actions bot commented Jan 9, 2023

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 9, 2023
@github-actions github-actions bot closed this as completed Feb 8, 2023
@pierDipi
Copy link
Member

pierDipi commented Feb 8, 2023

/reopen

@knative-prow knative-prow bot reopened this Feb 8, 2023
@knative-prow
Copy link

knative-prow bot commented Feb 8, 2023

@pierDipi: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 9, 2023
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 11, 2023
@pierDipi pierDipi reopened this Jun 12, 2023
@pierDipi
Copy link
Member

/triage accepted

@knative-prow knative-prow bot added the triage/accepted Issues which should be fixed (post-triage) label Jun 12, 2023
@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/eventing kind/functions priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Development

No branches or pull requests

3 participants