Skip to content
This repository has been archived by the owner on Sep 6, 2019. It is now read-only.

Ability to specify Jib version. #76

Open
saturnism opened this issue Nov 7, 2018 · 4 comments
Open

Ability to specify Jib version. #76

saturnism opened this issue Nov 7, 2018 · 4 comments

Comments

@saturnism
Copy link

Currently, Jib builder always use the latest version of the released plugin. For consistency/reproducibility, user may want to specify a specific version of Jib.

Add JIB_VERSION argument and default to RELEASE.
In the Jib step, use plugin coordinate com.google.cloud.tools:jib-maven-plugin:${JIB_VERSON}:build

@saturnism
Copy link
Author

saturnism commented Nov 7, 2018

/cc @coollog wdyt?

@coollog
Copy link
Contributor

coollog commented Nov 7, 2018

Sounds good! Will add this in

@saturnism
Copy link
Author

hmm, i wonder if the version here will override the actual plugin version specified by the pom?
another way of doing this to specify the plugin version in the build file. that's actually really good too.

@coollog
Copy link
Contributor

coollog commented Nov 19, 2018

Yea, the user can definitely specify the plugin version in the build file, but the JIB_VERSION build template argument can be made to override that (so a default empty JIB_VERSION would call com.google.cloud.tools:jib-maven-plugin::build, which would use the project-specified version).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants