Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the DVD Controller #265

Open
kmcurry opened this issue Jan 8, 2015 · 1 comment
Open

Refactor the DVD Controller #265

kmcurry opened this issue Jan 8, 2015 · 1 comment

Comments

@kmcurry
Copy link
Owner

kmcurry commented Jan 8, 2015

The "DVD Controller" is responsible for play, pause, stop, fast forward and rewind of animation in the 3D scene.

dvd-controller

The UI is currently buried on the Slides tab of the sidebar panel (line 578 in create.ejs).

screen shot 2014-12-15 at 9 47 23 am

Group the button elements into a div with id="DVDControls" and move the div to sidebar panel so that the controls are always visible on the panel when it is open. They can go above the tabs ("Objects", "Slides").

While testing:

  • Load Egypt, Two-Stroke and Light and confirm the control works as expected
  • Animate some objects and confirm the control works as expected
  • Report unexpected behavior in the comments below

In the future:

  • We'll reuse the controls on other panels or ui configurations.
@kmcurry kmcurry added the bug label Jan 8, 2015
@kmcurry
Copy link
Owner Author

kmcurry commented Jan 12, 2015

Possibly move DVD control

@kmcurry kmcurry changed the title Sometimes DVD Controller doesn't work Refactor the DVD Controller Jan 12, 2015
@kmcurry kmcurry added enhancement and removed bug labels Jan 12, 2015
@kmcurry kmcurry added the Coding label Jan 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants