Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firefox support #69

Open
naslundx opened this issue Nov 16, 2020 · 4 comments · Fixed by #70
Open

Firefox support #69

naslundx opened this issue Nov 16, 2020 · 4 comments · Fixed by #70
Labels
enhancement New feature or request

Comments

@naslundx
Copy link
Collaborator

Support changing browser to Firefox.

  • MHTML support may come later if it requires special extension
@naslundx naslundx mentioned this issue Nov 16, 2020
Merged
@naslundx
Copy link
Collaborator Author

Still to do:

  • Work out how to get JS logs/output from firefox
  • Ensure all settings are respected when init firefox
  • Add firefox+geckodriver to docs
  • Add firefox+geckodriver to automatic tests
  • Test run all examples, fix bugs

@naslundx
Copy link
Collaborator Author

Regarding logs: In javascript.py there is a safe_selenium_method method. In the finally block is where the logs are (supposed to be) fetched

@naslundx
Copy link
Collaborator Author

naslundx commented Nov 20, 2020 •
edited by vonNiklasson
Loading

Regarding tests - the more complex tests are in system_test.py. We can hopefully do much more.

@naslundx naslundx reopened this Nov 26, 2020
@naslundx naslundx added bug Something isn't working enhancement New feature or request labels Nov 26, 2020
@naslundx naslundx mentioned this issue Dec 8, 2020
Merged
@naslundx naslundx removed the bug Something isn't working label Dec 8, 2020
@naslundx
Copy link
Collaborator Author

naslundx commented Dec 8, 2020

Moved JS logging to separate issue #97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added basic Firefox support klarna-incubator/webtraversallibrary
1 participant
@naslundx