Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: deploy l1 contracts on dockerized anvil node in local-rpc #1285

Open
enitrat opened this issue Jul 7, 2024 · 2 comments
Open

dev: deploy l1 contracts on dockerized anvil node in local-rpc #1285

enitrat opened this issue Jul 7, 2024 · 2 comments
Labels
enhancement Enhancement of the code, not introducing new features.

Comments

@enitrat
Copy link
Contributor

enitrat commented Jul 7, 2024

following #1284 we have an anvil node that acts as the settlement layer used with Katana.

in .katana/messaging_config.json we hardcoded the address of the StarknetMessaging contract - but it would be better to, in the docker-compose, deploy the StarknetMessaging and L1KakarotMessaging contracts and put them in the .env to make it more robust.
@enitrat enitrat added the enhancement Enhancement of the code, not introducing new features. label Jul 7, 2024
anukkrit149 pushed a commit to karnotxyz/kakarot-rpc that referenced this issue Aug 9, 2024
@ClementWalter @enitrat
Use transparent proxy for accounts (kkrt-labs#1285)
c366211 
## Pull request type

Please check the type of change your PR introduces:

- [ ] Bugfix
- [x] Feature
- [ ] Code style update (formatting, renaming)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] Documentation content changes
- [ ] Other (please describe):

## What is the current behavior?

Accounts have their own implementation and needs to be upgraded when
Kakarot is.

Resolves kkrt-labs#1280
Resolves kkrt-labs#1275

## What is the new behavior?

Accounts class is never updated and is a transparent proxy. Each call to
the account starts by fetching
the current implementation in Kakarot, then make a `library_call`.

<!-- Reviewable:start -->
- - -
This change is [<img src="https://reviewable.io/review_button.svg"
height="34" align="absmiddle"
alt="Reviewable"/>](https://reviewable.io/reviews/kkrt-labs/kakarot/1285)
<!-- Reviewable:end -->

---------

Co-authored-by: enitrat <[email protected]>
@greged93
Copy link
Collaborator

greged93 commented Oct 1, 2024

@enitrat is this done?

@enitrat
Copy link
Contributor Author

enitrat commented Oct 1, 2024

no, this is still relying on the dynamic addresses deployed on the anvil node. As long as the order of deployment and the key account used to deploy are the same, this is not an issue because they will always have the same addresses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Enhancement of the code, not introducing new features.
Projects
Kakarot's Project Management
Status: 🆕 Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@enitrat @greged93