Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allocation of icu transliterator in removeAccents on apple fails #1101

Open
mgautierfr opened this issue Jul 15, 2024 · 2 comments
Open

Allocation of icu transliterator in removeAccents on apple fails #1101

mgautierfr opened this issue Jul 15, 2024 · 2 comments

Comments

@mgautierfr
Copy link
Member

See kiwix/kiwix-apple#851

From first investigation, from trace, apple application is using icu73.
But we are loading icu data version 58 (https://github.com/kiwix/libkiwix/blob/main/src/tools/stringTools.cpp#L39-L49)
There is something wrong ?

@BPerlakiH Are you calling the method loadICUExternalTables first ?

@BPerlakiH
Copy link

I have investigated this further. The issue will be fixed on the Apple side here:
kiwix/kiwix-apple#868

The reason it was failing is that we had calls to Kiwix::Manager->readOPDS() from multiple threads at the same time!

From the more detailed crash report, I can see that both Thread 1 and Thread 6 are calling the same:

Screenshot 2024-07-15 at 12 16 03 Screenshot 2024-07-15 at 12 15 55

@kelson42 kelson42 added this to the 13.2.0 milestone Jul 15, 2024
@kelson42
Copy link
Collaborator

From first investigation, from trace, apple application is using icu73.
But we are loading icu data version 58 (https://github.com/kiwix/libkiwix/blob/main/src/tools/stringTools.cpp#L39-L49)

We do use version 73, see https://github.com/kiwix/kiwix-build/blob/main/kiwixbuild/dependencies/icu4c.py#L17. The only question is why do we use what looks like to be an outdated .dat file!?

@kelson42 kelson42 modified the milestones: 14.0.0, 14.1.0 Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants