Crash reports are ignored without error if Fabric is not initialized

[apaatsio]

Problem

I managed to produce a situation where I had a crash very soon after the launch of the app when Fabric wasn't fully initialized yet. In such case, a call to FlutterCrashlytics().reportCrash() returns successfully even though it doesn't actually report the crash.

The problem is the else branch here:

flutter_crashlytics/android/src/main/java/com/kiwi/fluttercrashlytics/FlutterCrashlyticsPlugin.java

Lines 36 to 40 in e14aa46

	if (Fabric.isInitialized()) {
	onInitialisedMethodCall(methodCall, result);
	} else {
	result.success(null);
	}

As can be seen, it always returns succesully, even when Fabric is not initialized.

Possible solution

Instead of calling result.success(null), do something like this so that the caller can retry later if they want to:

if (Fabric.isInitialized()) {
  onInitialisedMethodCall(methodCall, result);
} else {
  result.error('CRASHLYTICS_NOT_FULLY_INITIALIZED_YET');
}

[jaumard]

Hi @apaatsio, we can't return an error, the reason we return a success is because if you ask permission to retrieve data to your user (as you must do in Europe because of the law) user can say no so you'll not call initialized to not have it enabled. But you don't want to all your report the throw an exception after that as it's expected.

What I don't understand is how can you have a crash before initializing fabric ? that's the first thing you should do and await the initialized call to be sure it's initialized after that.

[apaatsio]

I'm using await.

I believe Fabric.with() is asynchronous under the hood and that's causing the issue.

I added logging like this:

if (methodCall.method.equals("initialize")) {
    Fabric.with(context, new Crashlytics(), new CrashlyticsNdk());
    Log.d("FlutterCrashlytics", "Fabric.isInitialized:" + Fabric.isInitialized());
    result.success(null);
}

and it prints false. So, Fabric is not initialized instantly after running Fabric.with().

[jaumard]

Shit, dawn Fabric ^^
Are you able to reproduce on both Android and iOS ? or just one platform ?
I need to think of a way to fixing this...

[apaatsio]

@jaumard I have experienced this only on Android since I don't have an Apple device to test on.

[jaumard]

From the doc:

public static boolean isInitialized()
Returns true when all kits have finished asynchronous initialization.

so problem is only on Android as iOS API doesn't have this isInitialized method ^^

So maybe the fix is just not to use this method and have a boolean into the class instead.
What do you think ? Can you test that ?