Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReadMe is incomplete & confusing #60

Open
gitmoto opened this issue Feb 22, 2019 · 2 comments
Open

ReadMe is incomplete & confusing #60

gitmoto opened this issue Feb 22, 2019 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@gitmoto
Copy link

gitmoto commented Feb 22, 2019

I found the ReadMe.md file to be very confusing. Here are some of the issues with it:

  1. Fabric & Firebase instructions are intermingled. Consider having 2 separate installation sections. One for Fabric & one for Firebase
  2. What does this mean? Where does it go? Just run this in a terminal? "And apply the fabric plugin apply plugin: 'io.fabric'"
  3. Does this instruction apply to ALL of the iOS instructions? Or just the top part? "On iOS side your need to set your Fabric ID under your Info.plist like: (Only do this if using Fabric, not Firebase as you will not have an Api Key)"
  4. In the Flutter implementation instructions, it says this "Your main method should look like:" but it doesn't say anything about including this import statement: "import "dart:async";" I had to find it by googling to figure out what Zone meant
@jmrboosties
Copy link

I'm still a bit unclear on how the run script step should work. I get the part where we add the input file, but the entry below shell is a bit unclear. In the example, he has a screenshot of $(PODS_ROOT)/Fabric/Run, followed by a hash. My Flutter project defaulted this value to

/bin/sh "$FLUTTER_ROOT/packages/flutter_tools/bin/xcode_backend.sh" build

Just a bit unclear on if that goes before/after or what.

@jaumard jaumard added good first issue Good for newcomers help wanted Extra attention is needed labels May 5, 2019
@tomk9
Copy link

tomk9 commented Sep 18, 2019

I'm still a bit unclear on how the run script step should work. I get the part where we add the input file, but the entry below shell is a bit unclear. In the example, he has a screenshot of $(PODS_ROOT)/Fabric/Run, followed by a hash. My Flutter project defaulted this value to

/bin/sh "$FLUTTER_ROOT/packages/flutter_tools/bin/xcode_backend.sh" build

Just a bit unclear on if that goes before/after or what.

You should follow official Firebase instruction https://firebase.google.com/docs/crashlytics/get-started?authuser=0#initialize
The most important step is Click + Add a new build phase, then select New Run Script Phase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants