-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why is mongodb included as a peerDependency? #179
Comments
Similar reasons to https://nodejs.org/en/blog/npm/peer-dependencies/ . Things like https://github.com/kissjs/node-mongoskin/blob/master/lib/helper.js won't work quite right if you have mongoskin depending on one version of mongodb and are using another version of mongodb. |
What if someone upgrades the root mongodb installation? Won't that potentially cause problems for mongoskin? |
In theory no, mongoskin is meant to be a much thinner layer on top of the mongodb driver than say mongoose. As a matter of fact, nowadays the features mongoskin provides that the mongodb driver doesn't are pretty limited, mostly just |
Ok. Thanks for the clarification. |
Seems like it would be more appropriate to include it as a regular dependency. I've seen some weird npm install/uninstall behaviour related to this.
The text was updated successfully, but these errors were encountered: