Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow back scroll on KeyboardAwareScollView on some Android devices #335

Closed
kirillzyusko opened this issue Jan 18, 2024 · 1 comment · Fixed by #342
Closed

Slow back scroll on KeyboardAwareScollView on some Android devices #335

kirillzyusko opened this issue Jan 18, 2024 · 1 comment · Fixed by #342
Assignees
Labels
🤖 android Android specific 📚 components Anything related to the exported components of this library KeyboardAwareScrollView 📜 Anything related to KeyboardAwareScrollView component

Comments

@kirillzyusko
Copy link
Owner

Describe the bug

Slow back scroll on KeyboardAwareScollView on Xiaomi Redmi Note 5 Pro (Android 9).

Code snippet
Add your code snippet where error has been occurred.

Repo for reproducing
I would be highly appreciate if you can provide repository for reproducing your issue. It can significantly reduce the time for discovering and fixing the problem.

To Reproduce
Steps to reproduce the behavior:

  1. Go to AwareScrollView example
  2. Click on TextInput 8/9
  3. Close the keyboard
  4. Observe animation performance

Expected behavior

We should see a smooth animation.

Screenshots

telegram-cloud-document-2-5280808452464067335.mp4

Smartphone (please complete the following information):

  • Desktop OS: Mac OS 14.2.1
  • Device: Xiaomi Redmi Note 5 Pro
  • OS: Android 9
  • RN version: 0.72.4
  • RN architecture: old
  • JS engine: Hermes
  • Library version: 1.10.2

Additional context

Initially was reported in #255 (comment) but finally it's reproducible on device that I have at my hands 😊

@kirillzyusko kirillzyusko added 🤖 android Android specific 📚 components Anything related to the exported components of this library labels Jan 18, 2024
@kirillzyusko kirillzyusko self-assigned this Jan 18, 2024
@kirillzyusko
Copy link
Owner Author

Seems like a problem is in useSmoothKeyboardHandler hook. If we use direct events on all Android versions then everything works very smooth.

My assumption is that events maybe somehow delayed and we are trying to scroll to wrong (unachievable?) position and some frames of animations are getting skipped. Interesting issue - I'm working on it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 android Android specific 📚 components Anything related to the exported components of this library KeyboardAwareScrollView 📜 Anything related to KeyboardAwareScrollView component
Projects
None yet
1 participant