useFocusedInputHandler and onChangeText handler ignores an input from react-native-text-input-mask on iOS
#330
Assignees
Labels
🐛 bug
Something isn't working
focused input 📝
Anything about focused input functionality
🍎 iOS
iOS specific
Comments
kirillzyusko
added
🐛 bug
2 tasks
kirillzyusko
added a commit
that referenced
this issue
Jan 21, 2024
…nput from `react-native-text-input-mask` on iOS (#341) ## 📜 Description Fixed a problem when `onTextChange` is not fired on iOS if `TextInput` from `react-native-text-input-mask`. ## 💡 Motivation and Context The issue and solution is described [here](https://github.com/RedMadRobot/input-mask-ios?tab=readme-ov-file#uitextfieldtextdidchange-notification-and-target-action-editingchanged-event). However, if I add delegate with `onEditingChanged` method, then I can not assign my listener to this callback (the delegate can not be casted to my own type and I can not import existing class from another module because RNKC is not depending on another module). And adding an optional dependency to Podfile makes installation process harder and I don't see explicit benefits of making the approach more complex. For now I'll go with this solution (also I opened a PR to `react-native-text-input-mask`, see react-native-text-input-mask/react-native-text-input-mask#305). Maybe later I'll revisit and make it more sophisticated, but for now we have a working solution and I'm pretty happy with that. Closes #330 ## 📢 Changelog ### Docs - add a reference to the known problem (it should be fixable by applying a patch); ### E2E - added new test to check that `react-native-text-input-mask` integration works; ### JS - changed icon for `react-native-text-input-mask` example; - specified `black` color for TextInput in `react-native-text-input-mask` example; - patched `react-native-text-input-mask` library; ## 🤔 How Has This Been Tested? Tested on iPhone 15 Pro 17.2 ## 📸 Screenshots (if appropriate): |Before|After| |------|------| ||| ## 📝 Checklist - [x] CI successfully passed - [x] I added new mocks and corresponding unit-tests if library API was changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
useFocusedInputHandlerandonChangeTexthandler ignores an input fromreact-native-text-input-maskon iOSCode snippet
Example app.
Repo for reproducing
Example app.
To Reproduce
Steps to reproduce the behavior:
Text input maskscreenTextInputExpected behavior
In
workletsection you should see an output of what user typed.Screenshots
Smartphone (please complete the following information):
Additional context
https://github.com/RedMadRobot/input-mask-ios?tab=readme-ov-file#uitextfieldtextdidchange-notification-and-target-action-editingchanged-event
The text was updated successfully, but these errors were encountered: