Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Make usePopover default behavior in dropdown #3696

Open
1 of 11 tasks
RasmusKjeldgaard opened this issue Nov 5, 2024 · 0 comments
Open
1 of 11 tasks

[Enhancement] Make usePopover default behavior in dropdown #3696

RasmusKjeldgaard opened this issue Nov 5, 2024 · 0 comments
Labels
enhancement New feature or request 👶🏻 New For new issues before prioritisation and refinement NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Tech refined Needs Tech kickoff - solution outlined and agreed

Comments

@RasmusKjeldgaard
Copy link
Collaborator

RasmusKjeldgaard commented Nov 5, 2024

Describe the enhancement

There are some reports about dropdown not correctly placing itself on top of content , e.g. #3691 and others raised in our support channels. These have proven to be solved by usePopover="true", so we should make it the default. It is battle-tested, and known issues have been solved as per #2087.

Solving this issue will also solve above mentioned issue (#2087).

Also, consumers have to explicitly set usePopover for dropdown in calendar, which is not ideal, and would also be solved by this.

Describe the solution you'd like

Make usePopover true by default and deprecate the input all together, by warning when it is set. Remove the input all together in the next major.

Are there any additional context?


Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Refinement

  • Request that the issue is UX refined
  • Request that the issue is tech refined; do not proceed until this is done.

Implementation

The contributor who wants to implement this issue should:

  • Make sure you have read: "Before you get coding".
  • Signal to others you are working on the issue by assigning yourself.
  • Create a branch from the develop branch following our branch naming convention.
  • Publish a WIP implementation to Github as a draft PR and ask for feedback.
  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Update the cookbook with examples and showcases.

Review

Once the issue has been implemented and is ready for review:

  • Do a self-review.
  • Create a pull-request. If you created a draft PR during implementation you can just mark that as "ready for review".
@RasmusKjeldgaard RasmusKjeldgaard added enhancement New feature or request NOT Tech refined Needs Tech kickoff - solution outlined and agreed NOT Prioritized Issue not yet prioritized and added to a Milestone 👶🏻 New For new issues before prioritisation and refinement labels Nov 5, 2024
@github-project-automation github-project-automation bot moved this to 📙 Backlog in Kirby Sprints Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 👶🏻 New For new issues before prioritisation and refinement NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Tech refined Needs Tech kickoff - solution outlined and agreed
Projects
Status: 📙 Backlog
Development

No branches or pull requests

1 participant