You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The following tasks should be completed to improve the a11y of the Modal component:
Ensure modal is labelled with a title
This can be achieved by associating ion-title of modal-wrapper.component.html to ion-modal through aria-labelledby. This could be set on the ionModalElement instance in ModalWrapperComponent.ngOnInit. Please note:ion-title will need a unique id.
More info: https://ionicframework.com/docs/api/modal#labels
Ensure the close button is labelled with a title
This can be achieved by setting aria-label on the button in modal-wrapper.component.html since it's an icon only button with no text. Please note: The title should be localized (da + en).
Describe the enhancement
The following tasks should be completed to improve the a11y of the Modal component:
ion-title
ofmodal-wrapper.component.html
toion-modal
througharia-labelledby
. This could be set on theionModalElement
instance inModalWrapperComponent.ngOnInit
.Please note:
ion-title
will need a unique id.More info: https://ionicframework.com/docs/api/modal#labels
aria-label
on the button inmodal-wrapper.component.html
since it's an icon only button with no text.Please note: The title should be localized (da + en).
Describe the solution you'd like
Have you considered any alternatives?
Are there any additional context?
Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Refinement
Implementation
The contributor who wants to implement this issue should:
Review
Once the issue has been implemented and is ready for review:
The text was updated successfully, but these errors were encountered: