Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Housekeeping] Setup Cypress #3446

Closed
4 tasks
jakobe opened this issue Apr 22, 2024 · 1 comment
Closed
4 tasks

[Housekeeping] Setup Cypress #3446

jakobe opened this issue Apr 22, 2024 · 1 comment
Assignees

Comments

@jakobe
Copy link
Collaborator

jakobe commented Apr 22, 2024

  • Add Cypress dep(s)
  • Setup Component testing (for 1 existing component, e.g. Badge)
  • Investigate Chromatic support for component tests
    • If not supported, investigate e2e Cypress tests x Chromatic

Scope:

  • Focus on getting Cypress test up and running
  • validate for simple components (e.g. badge, button etc)
  • spike on Chromatic support
  • validate if this is what we want

Descope:

  • actual Chromatic integration comes later (descope)
  • complex components come later (e.g. Modal)
@jakobe jakobe self-assigned this Apr 22, 2024
@jakobe jakobe moved this to 📙 Backlog in Kirby Sprints Apr 22, 2024
@jakobe jakobe moved this from 📙 Backlog to 🚀 In Progress in Kirby Sprints Apr 22, 2024
@jakobe
Copy link
Collaborator Author

jakobe commented May 6, 2024

Short summary:
Cypress snapshots (serializes) the markup and styles which are sent to Chromatic and recreated (deserialized) and then snapshotted as and image. This doesn't play well with Web Comps, as the deserialized view doesn't contain the styles of the web component :(
See more in this issue: chromaui/chromatic-e2e#129

TL;DR: Cypress+Chromatic doesn't seem the best fit for us at the moment - maybe stick with Storybook for visual snapshots?

@jakobe jakobe closed this as completed May 6, 2024
@github-project-automation github-project-automation bot moved this from 🚀 In Progress to ✅ Done in Kirby Sprints May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

1 participant