Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: createKindeBrowserClient uses server sessionManager type #39

Open
4 tasks done
luukhaijes opened this issue Dec 22, 2023 · 2 comments
Open
4 tasks done

Bug: createKindeBrowserClient uses server sessionManager type #39

luukhaijes opened this issue Dec 22, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@luukhaijes
Copy link

Prerequisites

Describe the issue

When trying to override the sessionManager when using createKindeBrowserClient it still expects the server sessionManager and not the browserSessionManager. On browser the lib uses browser specific sessionManager. I also noticed that there is no type available for it, since it is an option on BrowserPKCEClientOptions.

Library URL

https://github.com/kinde-oss/kinde-typescript-sdk

Library version

2.5.0

Operating system(s)

macOS

Operating system version(s)

13.5

Further environment details

No response

Reproducible test case URL

No response

Additional information

No response

@luukhaijes luukhaijes added the bug Something isn't working label Dec 22, 2023
@luukhaijes
Copy link
Author

I'm able to contribute and fix this issue, would first like to know if I'm missing something.

@coel
Copy link
Member

coel commented Jan 12, 2024

Thank you for raising this @luukhaijes, I'm actually not entirely sure why we have a separate interface for the browser session manager, let me do some investigation and get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants