Merge pull request #33 from xiaoshenlin/main

Allow `createKindeBrowserClient` with custom `SessionManager`
kinde-oss · Nov 29, 2023 · 51f02d7 · 51f02d7
2 parents 75d395c + 5be1808
commit 51f02d7
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/lib/sdk/clients/browser/authcode-with-pkce.ts b/lib/sdk/clients/browser/authcode-with-pkce.ts
@@ -13,12 +13,12 @@ import type {
   CreateOrgURLOptions,
   RegisterURLOptions,
   LoginURLOptions,
-  PKCEClientOptions,
+  BrowserPKCEClientOptions,
 } from '../types.js';
 
-const createAuthCodeWithPKCEClient = (options: PKCEClientOptions) => {
+const createAuthCodeWithPKCEClient = (options: BrowserPKCEClientOptions) => {
   const { featureFlags, tokenClaims } = utilities;
-  const sessionManager = new BrowserSessionManager();
+  const sessionManager = options.sessionManager ?? new BrowserSessionManager();
   const client = new AuthCodeWithPKCE(options);
 
   /**

diff --git a/lib/sdk/clients/browser/index.ts b/lib/sdk/clients/browser/index.ts
@@ -1,8 +1,8 @@
 import createAuthCodeWithPKCEClient from './authcode-with-pkce.js';
 import { isBrowserEnvironment } from '../../environment.js';
-import type { PKCEClientOptions } from '../types.js';
+import type { BrowserPKCEClientOptions } from '../types.js';
 
-export const createKindeBrowserClient = (options: PKCEClientOptions) => {
+export const createKindeBrowserClient = (options: BrowserPKCEClientOptions) => {
   if (!isBrowserEnvironment()) {
     throw new Error('this method must be invoked in a browser environment');
   }

diff --git a/lib/sdk/clients/types.ts b/lib/sdk/clients/types.ts
@@ -6,6 +6,11 @@ import type {
   AuthorizationCodeOptions,
   AuthURLOptions,
 } from '../oauth2-flows/index.js';
+import { type SessionManager} from "../session-managers";
+
+export interface BrowserPKCEClientOptions extends AuthorizationCodeOptions {
+  sessionManager?: SessionManager
+}
 
 export interface PKCEClientOptions extends AuthorizationCodeOptions {}
 export interface CCClientOptions extends ClientCredentialsOptions {}