Update to coffeescript 2 and ember-cli 3.0 #149
Conversation
| @@ -4,9 +4,9 @@ | |||
| var STRING_DASHERIZE_REGEXP = (/[ _]/g); | |||
| var STRING_DASHERIZE_CACHE = {}; | |||
| var STRING_DECAMELIZE_REGEXP = (/([a-z\d])([A-Z])/g); | |||
| var STRING_CAMELIZE_REGEXP = (/(\-|_|\.|\s)+(.)?/g); | |||
| var STRING_CAMELIZE_REGEXP = (/(-|_|\.|\s)+(.)?/g); | |||
There was a problem hiding this comment.
eslint flagged some unneeded escape characters in these regexes
|
Is there anything else that needs to be done to get this merged? |
|
@jakesjews Thank you so much for looking at this! I was wondering: How do these changes affect compatibility? Could I still install Does this change required Node versions for the project? I merged some changes, so there are some conflicts that need resolving - sorry about that. |
|
@kimroen merged up now. Coffeescript 2.0 requires node version 6 or greater. I'm not quite sure if it works on ember 1.13 or not but I think it has reached EOL. |
|
you can definitely use the older versions with ember older versions by pinning the requirement. but 1.13 is EOL |
|
It would be awesome to get this PR merged. I suggest making this version |
|
@kimroen - ping. :) |
|
@kimroen re-ping, This has now become urgent as the new Ember testing API's use async everywhere |
|
+1 and thanks, @jakesjews, great job! Hope it's merged soon, we also depend on coffeescript and use async api. |
|
If anyone wants to use it I have published https://www.npmjs.com/package/eflex-ember-cli-coffeescript which uses coffeescript 2.0. The company I work for has been using it in production for a long time now. |
|
That's awesome! We were using your branch in dev, but now that it's published as a separate package, will definitely switch to it. |
|
@jakesjews Would you be interested in helping maintain this package? The main reason I haven't done anything with this is that I have bigger plans for what I want to do with it, but I just never seem to find the time and energy for it. |
|
@kimroen yeah I'm definitely willing to help |
|
Any action here? :) |
Resolves #144
This should also resolve #112 since joliss/broccoli-coffee#20 was resolved in the latest broccoli-coffee