Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New docs site issue: Black area displayed when video is being played #505

Closed
reshmabidikar opened this issue Aug 1, 2023 · 4 comments
Closed
Assignees

Comments

@reshmabidikar
Copy link
Contributor

reshmabidikar commented Aug 1, 2023

When a video is being played on the docs site, UI displays a black area above and below the video:

black-space-around-video

Not sure if this has something to do with the browser/screen resolution.

@reshmabidikar
Copy link
Contributor Author

#515 addresses this. The video now plays in a new browser window that opens youtube.com. It displays youtube ads. The docs site displays the video preview screen.

The following screen recording demonstrates this:

https://www.loom.com/share/d5b0c00d9bea4212b3b0679da8a3395f?sid=3b3a0859-a576-4acc-a603-255508a1ce2e

@pierre Is this the desired behavior?

@pierre
Copy link
Member

pierre commented Aug 23, 2023

Good catch, without YT Premium, one has ads 😞 I've filed #518 for tracking.

@pierre pierre closed this as completed Aug 23, 2023
@deekant
Copy link
Contributor

deekant commented Aug 23, 2023

@reshmabidikar @pierre these are two different videos. This issue started for embedded video with black areas on the index page https://new-branding.docs-killbill-io.pages.dev/ and it's fixed there.

And the second one is on https://new-branding.docs-killbill-io.pages.dev/latest/what_is_kill_bill with a popup and redirect to Youtube. Maybe we make it embedded as well?

@pierre
Copy link
Member

pierre commented Aug 23, 2023

Yup, that sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants