Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can you help make lora training with one trainer work? #315

Open
pondloso opened this issue Jan 30, 2025 · 3 comments
Open

can you help make lora training with one trainer work? #315

pondloso opened this issue Jan 30, 2025 · 3 comments

Comments

@pondloso
Copy link

pondloso commented Jan 30, 2025

When load lora it will give "lora key not load" error
but if i disable single block it load without error but lora it had no impact at all.

for comfy core it also had same error but after patch with this

comfyanonymous/ComfyUI#6531 (comment)

it still give error but lora seem to work fine(or had clear impact)
I dont know how to patch with your node.
I dont want to use comfy core node it mo block swap and hard to complie it really slow .

Thank you for your hard work again.

@kijai
Copy link
Owner

kijai commented Jan 31, 2025

I'm actually using comfy core for the LoRA loading, so same fix there should apply here.

@pondloso
Copy link
Author

Thank you for answer.
I test in many way but my train lora still not load with your node,other lora work fine.
Look like i need to wait for official lora update from comfy core.

@Ratinod
Copy link

Ratinod commented Feb 3, 2025

Look like i need to wait for official lora update from comfy core.

Apparently there won't be an update:
comfyanonymous/ComfyUI#6673 (comment)
comfyanonymous/ComfyUI#6531 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants