From 3648058ea131ccd2eaa7aafef0fd027dafcb9ef9 Mon Sep 17 00:00:00 2001
From: Jette Petzold <jep@informatik.uni-kiel.de>
Date: Thu, 19 Dec 2024 14:47:46 +0100
Subject: [PATCH] mka feedback

---
 extension/src-context-table/tsconfig.json                       | 2 +-
 extension/src-diagram-snippets/tsconfig.json                    | 2 +-
 extension/src-language-server/main.ts                           | 2 +-
 extension/src-language-server/tsconfig.json                     | 2 +-
 extension/src-webview/context-menu/context-menu-provider.ts     | 2 +-
 .../feather-icons-snabbdom/feather-icons-snabbdom.tsx           | 2 +-
 extension/src-webview/options/options-panel.tsx                 | 2 +-
 extension/src-webview/tsconfig.json                             | 2 +-
 extension/src/extension.ts                                      | 2 +-
 extension/src/tsconfig.json                                     | 2 +-
 extension/src/utils.ts                                          | 2 ++
 11 files changed, 12 insertions(+), 10 deletions(-)

diff --git a/extension/src-context-table/tsconfig.json b/extension/src-context-table/tsconfig.json
index 327c8d8..c745803 100644
--- a/extension/src-context-table/tsconfig.json
+++ b/extension/src-context-table/tsconfig.json
@@ -12,4 +12,4 @@
     "jsx": "react",
     "jsxFactory": "jsx"
   }
-}
\ No newline at end of file
+}
diff --git a/extension/src-diagram-snippets/tsconfig.json b/extension/src-diagram-snippets/tsconfig.json
index e85cb61..dcb44ee 100644
--- a/extension/src-diagram-snippets/tsconfig.json
+++ b/extension/src-diagram-snippets/tsconfig.json
@@ -10,5 +10,5 @@
     "module": "commonjs",
     "moduleResolution": "node",
     "jsx": "react",
+  }
 }
-}
\ No newline at end of file
diff --git a/extension/src-language-server/main.ts b/extension/src-language-server/main.ts
index 5a6fa6e..b9e99b7 100644
--- a/extension/src-language-server/main.ts
+++ b/extension/src-language-server/main.ts
@@ -38,4 +38,4 @@ addDiagramHandler(connection, shared);
 
 addSTPANotificationHandler(connection, stpa, shared);
 addFTANotificationHandler(connection, fta, shared);
-addNotificationHandler(connection, shared, stpa, fta);
\ No newline at end of file
+addNotificationHandler(connection, shared, stpa, fta);
diff --git a/extension/src-language-server/tsconfig.json b/extension/src-language-server/tsconfig.json
index 795e550..4d6b139 100644
--- a/extension/src-language-server/tsconfig.json
+++ b/extension/src-language-server/tsconfig.json
@@ -11,4 +11,4 @@
     "moduleResolution": "Node16",
   },
   "exclude": ["../src-context-table"]
-}
\ No newline at end of file
+}
diff --git a/extension/src-webview/context-menu/context-menu-provider.ts b/extension/src-webview/context-menu/context-menu-provider.ts
index 91925e8..db93feb 100644
--- a/extension/src-webview/context-menu/context-menu-provider.ts
+++ b/extension/src-webview/context-menu/context-menu-provider.ts
@@ -23,7 +23,7 @@ import { FTANode, FTA_GRAPH_TYPE, FTA_NODE_TYPE } from "../fta/fta-model";
 
 @injectable()
 export class ContextMenuProvider implements IContextMenuItemProvider {
-    getItems(root: Readonly<SModelRootImpl>, lastMousePosition?: Point): Promise<LabeledAction[]> {
+    getItems(root: Readonly<SModelRootImpl>, _lastMousePosition?: Point): Promise<LabeledAction[]> {
         if (root.type === FTA_GRAPH_TYPE) {
             // find node that was clicked on
             let clickedNode: FTANode | undefined;
diff --git a/extension/src-webview/feather-icons-snabbdom/feather-icons-snabbdom.tsx b/extension/src-webview/feather-icons-snabbdom/feather-icons-snabbdom.tsx
index 065f732..1410b00 100644
--- a/extension/src-webview/feather-icons-snabbdom/feather-icons-snabbdom.tsx
+++ b/extension/src-webview/feather-icons-snabbdom/feather-icons-snabbdom.tsx
@@ -46,4 +46,4 @@ export function FeatherIcon(props: { iconId: string }): VNode {
     class={classes}
     props={{innerHTML: icons[props.iconId].toString()}}
   />;
-}
\ No newline at end of file
+}
diff --git a/extension/src-webview/options/options-panel.tsx b/extension/src-webview/options/options-panel.tsx
index ccbef3f..3fe5880 100644
--- a/extension/src-webview/options/options-panel.tsx
+++ b/extension/src-webview/options/options-panel.tsx
@@ -57,4 +57,4 @@ export class OptionsPanel extends SidebarPanel {
     get icon(): VNode {
         return <FeatherIcon iconId={"sliders"}/>;
     }
-}
\ No newline at end of file
+}
diff --git a/extension/src-webview/tsconfig.json b/extension/src-webview/tsconfig.json
index ca52b8e..27f0d99 100644
--- a/extension/src-webview/tsconfig.json
+++ b/extension/src-webview/tsconfig.json
@@ -11,5 +11,5 @@
     "module": "commonjs",
     "moduleResolution": "node",
     "jsx": "react",
+  }
 }
-}
\ No newline at end of file
diff --git a/extension/src/extension.ts b/extension/src/extension.ts
index 4e89cba..e00427b 100644
--- a/extension/src/extension.ts
+++ b/extension/src/extension.ts
@@ -542,4 +542,4 @@ function registerDiagramSnippetWebview(manager: StpaLspVscodeExtension, context:
             manager.addSnippet(uri);
         })
     );
-}
\ No newline at end of file
+}
diff --git a/extension/src/tsconfig.json b/extension/src/tsconfig.json
index 4c7f7b4..dd01c61 100644
--- a/extension/src/tsconfig.json
+++ b/extension/src/tsconfig.json
@@ -10,4 +10,4 @@
     "moduleResolution": "node",
     "allowSyntheticDefaultImports": true
   }
-}
\ No newline at end of file
+}
diff --git a/extension/src/utils.ts b/extension/src/utils.ts
index 2e95133..30afd6a 100644
--- a/extension/src/utils.ts
+++ b/extension/src/utils.ts
@@ -20,6 +20,8 @@ import { LanguageClient } from "vscode-languageclient/node";
 import { StpaLspVscodeExtension } from "./language-extension";
 import { StorageService } from "./storage-service";
 
+// TODO: rename utils files to be more descriptive
+
 /**
  * Creates a quickpick containing the values "true" and "false". The selected value is set for the
  * configuration option determined by {@code id}.