Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pm 46209 plugin review #9

Closed
wants to merge 8 commits into from
Closed

Pm 46209 plugin review #9

wants to merge 8 commits into from

Conversation

jvs-kialo
Copy link
Contributor

No description provided.

@mk-kialo mk-kialo self-requested a review August 12, 2024 12:40
Copy link
Collaborator

@mk-kialo mk-kialo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! Just a few minor things I commented on.

Also, no idea why the CI suddenly broke. But that happened before your commits. I'll investigate.

styles.css Outdated Show resolved Hide resolved
styles.css Outdated Show resolved Hide resolved
templates/loading_page.mustache Outdated Show resolved Hide resolved
mod_form.php Outdated Show resolved Hide resolved
@mk-kialo
Copy link
Collaborator

Looks good, thank you! Just a few minor things I commented on.

Also, no idea why the CI suddenly broke. But that happened before your commits. I'll investigate.

Looks like it's a problem upstream in the moodle setup code we use: moodlehq/moodle-plugin-ci#309

@mk-kialo
Copy link
Collaborator

Merging this into our story branch PM-43058-moodle-groups-story manually with some minor adjustments (since some of the code on the story was changed versus the base for this PR).

@mk-kialo mk-kialo closed this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants