From df2e2e7dee2ad45085e436c9959d589f4b35d451 Mon Sep 17 00:00:00 2001 From: jvs-kialo Date: Thu, 30 May 2024 15:59:41 +0200 Subject: [PATCH] Disables self defeating linting rule --- composer.json | 2 +- lang/en/kialo.php | 56 ++++++++++++++++------------------------- tests/generator/lib.php | 1 + 3 files changed, 23 insertions(+), 36 deletions(-) diff --git a/composer.json b/composer.json index 46686fa..f7b3b7b 100644 --- a/composer.json +++ b/composer.json @@ -40,7 +40,7 @@ "phpcs --config-set default_standard moodle" ], "lint": [ - "phpcs --standard=moodle --ignore=vendor,development .", + "phpcs --standard=moodle --ignore=vendor,development -s .", "php-cs-fixer fix --dry-run --diff" ], "fix": [ diff --git a/lang/en/kialo.php b/lang/en/kialo.php index f27e7ce..499873f 100644 --- a/lang/en/kialo.php +++ b/lang/en/kialo.php @@ -33,8 +33,21 @@ defined('MOODLE_INTERNAL') || die(); $string['cachedef_nonces'] = "Used to store temporary nonces to secure LTI requests."; +$string['close_prompt'] = 'You can close this window now.'; $string['deploymentid'] = "Discussion Linked"; $string['discussion_title'] = 'Discussion'; +$string['errors:deeplinking'] = "Something went wrong with the discussion selection. Please try again."; +$string['errors:invalidrequest'] = "Invalid request"; +$string['errors:ltiauth'] = "Authentication failed due to an unexpected error. Please try again."; +$string['errors:missingcourseid'] = "Missing course id"; +$string['errors:missingdeploymentid'] = "Missing deployment id"; +$string['errors:missingidtoken'] = "Missing id token"; +$string['errors:missingsessiondata'] = "Missing session data"; +$string['errors:noguestaccess'] = "Guests cannot access this activity. Please log in."; +$string['errors:nopermissiontoview'] = "You do not have permission to view this activity."; +$string['errors:resourcelink'] = "Activity cannot be displayed due to an unexpected error. Please try again."; +$string['groupmode_off_info'] = 'Please note that Moodle groups are currently not automatically supported. (More info)'; +$string['groupmode_on_warning'] = 'Moodle groups are currently not automatically supported. If you use the Kialo Moodle Plugin with a course that has multiple groups, all groups will find themselves in the same Kialo discussion.

To manually set up Kialo discussions for each of your groups, please follow the instructions in our help center.

We will release automatic Moodle groups support in Q1 2024. Submit your email address to be notified when it is released.'; $string['hello'] = 'Hello World!'; $string['kialo:addinstance'] = 'Add a new Kialo Discussion'; $string['kialo:kialo_admin'] = 'Granted Admin rights in Kialo discussions'; @@ -43,35 +56,12 @@ $string['kialoname'] = 'Activity Name'; $string['kialosettings'] = 'Settings'; $string['modulename'] = 'Kialo Discussion'; +$string['modulename_help'] = 'The Kialo Discussion activity allows you to include a Kialo discussion in your Moodle course. Students can participate in the discussion directly from Moodle, without having to manually create Kialo accounts. Kialo discussions are a great way to teach and train critical thinking, argumentation and to facilitate thoughtful classroom discussions.'; +$string['modulename_link'] = 'https://support.kialo-edu.com/en/hc/moodle'; $string['modulenameplural'] = 'Kialo Discussions'; $string['pluginadministration'] = 'Edit Kialo Discussion'; $string['pluginname'] = 'Kialo Discussion'; -$string['select_discussion_help'] = - 'Opens Kialo in a new tab to select a discussion for this activity. You can create a Kialo account during this process if you don’t already have one.'; -$string['select_discussion'] = 'Select Discussion'; - -// Help texts. -$string['modulename_help'] = 'The Kialo Discussion activity allows you to include a Kialo discussion in your Moodle course. Students can participate in the discussion directly from Moodle, without having to manually create Kialo accounts. Kialo discussions are a great way to teach and train critical thinking, argumentation and to facilitate thoughtful classroom discussions.'; -$string['modulename_link'] = 'https://support.kialo-edu.com/en/hc/moodle'; - -// Displayed while redirecting to Kialo during the LTI flows. -$string['close_prompt'] = 'You can close this window now.'; -$string['redirect_loading'] = "Loading"; -$string['redirect_title'] = "Loading"; - -// Errors. -$string['errors:deeplinking'] = "Something went wrong with the discussion selection. Please try again."; -$string['errors:invalidrequest'] = "Invalid request"; -$string['errors:ltiauth'] = "Authentication failed due to an unexpected error. Please try again."; -$string['errors:missingcourseid'] = "Missing course id"; -$string['errors:missingdeploymentid'] = "Missing deployment id"; -$string['errors:missingidtoken'] = "Missing id token"; -$string['errors:missingsessiondata'] = "Missing session data"; -$string['errors:noguestaccess'] = "Guests cannot access this activity. Please log in."; -$string['errors:nopermissiontoview'] = "You do not have permission to view this activity."; -$string['errors:resourcelink'] = "Activity cannot be displayed due to an unexpected error. Please try again."; - -// Privacy API. +$string['privacy:metadata:kialo'] = 'User data needs to be exchanged with Kialo Edu in order to automatically create accounts for Moodle users on kialo-edu.com, and to make the user experience as seamless as possible.'; $string['privacy:metadata:kialo:courseid'] = 'The ID of the user’s course.'; $string['privacy:metadata:kialo:email'] = 'The email address is sent from Moodle to allow you to access your data on Kialo Edu.'; $string['privacy:metadata:kialo:fullname'] = 'Your full name is sent to Kialo Edu to allow a better user experience.'; @@ -82,14 +72,10 @@ $string['privacy:metadata:kialo:timezone'] = 'Your time zone preference is sent to Kialo Edu to automatically set the user time zone.'; $string['privacy:metadata:kialo:userid'] = 'The userid is sent from Moodle to allow you to access your data on Kialo Edu.'; $string['privacy:metadata:kialo:username'] = 'The user name is sent from Moodle to set the default user name on Kialo Edu.'; -$string['privacy:metadata:kialo'] = - 'User data needs to be exchanged with Kialo Edu in order to automatically create accounts for Moodle users on kialo-edu.com, and to make the user experience as seamless as possible.'; - -// Settings. -$string['groupmode_off_info'] = 'Please note that Moodle groups are currently not automatically supported. (More info)'; -$string['groupmode_on_warning'] = - 'Moodle groups are currently not automatically supported. If you use the Kialo Moodle Plugin with a course that has multiple groups, all groups will find themselves in the same Kialo discussion.

To manually set up Kialo discussions for each of your groups, please follow the instructions in our help center.

We will release automatic Moodle groups support in Q1 2024. Submit your email address to be notified when it is released.'; -$string["acceptterms_desc"] = - 'To enable the Kialo plugin you have to accept Kialo Edu’s Terms of Service on behalf of all users of this Moodle instance. Here is a link to our Privacy Policy and to our Data Security and Privacy Plan.'; +$string['redirect_loading'] = "Loading"; +$string['redirect_title'] = "Loading"; +$string['select_discussion'] = 'Select Discussion'; +$string['select_discussion_help'] = 'Opens Kialo in a new tab to select a discussion for this activity. You can create a Kialo account during this process if you don’t already have one.'; $string["acceptterms"] = "Accept Terms of Service"; +$string["acceptterms_desc"] = 'To enable the Kialo plugin you have to accept Kialo Edu’s Terms of Service on behalf of all users of this Moodle instance. Here is a link to our Privacy Policy and to our Data Security and Privacy Plan.'; $string["termsnotaccepted"] = 'You have to accept Kialo’s Terms of Service before you can enable the Kialo plugin.'; diff --git a/tests/generator/lib.php b/tests/generator/lib.php index fe7189c..6bf3b56 100644 --- a/tests/generator/lib.php +++ b/tests/generator/lib.php @@ -20,6 +20,7 @@ * @package mod_kialo * @copyright 2023 onwards, Kialo GmbH * @license https://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later + * @phpcs:disable PHPCompatibility.FunctionDeclarations.RemovedImplicitlyNullableParam.Deprecated */ class mod_kialo_generator extends testing_module_generator {