From b85b366a94cb34c384c2335e223e58537f45537f Mon Sep 17 00:00:00 2001 From: Mathias Kahl Date: Mon, 30 Sep 2024 18:55:16 +0200 Subject: [PATCH] PM-43593 review comments - removed superfluous feature - fixed comments --- db/upgrade.php | 4 ++-- lib.php | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/db/upgrade.php b/db/upgrade.php index 66aac88..c3459f3 100644 --- a/db/upgrade.php +++ b/db/upgrade.php @@ -37,11 +37,11 @@ function xmldb_kialo_upgrade($oldversion = 0): bool { $dbman = $DB->get_manager(); if ($oldversion < VERSION_GRADING_1) { - // Define field id to be added to kialo. + // Define field 'grade' to be added to kialo. $table = new xmldb_table('kialo'); $field = new xmldb_field('grade', XMLDB_TYPE_INTEGER, '10', false, XMLDB_NOTNULL, false, 100, null); - // Conditionally launch add field id. + // Conditionally launch add field 'grade'. if (!$dbman->field_exists($table, $field)) { $dbman->add_field($table, $field); } diff --git a/lib.php b/lib.php index 087559d..c996760 100644 --- a/lib.php +++ b/lib.php @@ -41,7 +41,6 @@ function kialo_supports($feature) { return true; case FEATURE_GRADE_HAS_GRADE: - case FEATURE_GRADE_OUTCOMES: return true; default: