From a29ae409776995b738cc47f61d1586e8afb01ba6 Mon Sep 17 00:00:00 2001
From: Mathias Kahl <mk@kialo.com>
Date: Wed, 28 Aug 2024 17:04:59 +0200
Subject: [PATCH] PM-46464 fix optional params

---
 classes/lti_flow.php            | 8 ++++----
 tests/classes/lti_flow_test.php | 4 +---
 view.php                        | 4 ++--
 3 files changed, 7 insertions(+), 9 deletions(-)

diff --git a/classes/lti_flow.php b/classes/lti_flow.php
index 2dc3517..f261b0e 100644
--- a/classes/lti_flow.php
+++ b/classes/lti_flow.php
@@ -141,8 +141,8 @@ public static function assign_lti_roles($context): array {
      * @param string $deploymentid
      * @param string $moodleuserid
      * @param string $discussionurl
-     * @param string $groupid
-     * @param string $groupname
+     * @param string|null $groupid
+     * @param string|null $groupname
      * @return LtiMessageInterface
      * @throws LtiExceptionInterface
      * @throws \coding_exception
@@ -154,8 +154,8 @@ public static function init_resource_link(
         string $deploymentid,
         string $moodleuserid,
         string $discussionurl,
-        string $groupid,
-        string $groupname
+        ?string $groupid = null,
+        ?string $groupname = null
     ): LtiMessageInterface {
         $context = context_module::instance($coursemoduleid);
         $roles = self::assign_lti_roles($context);
diff --git a/tests/classes/lti_flow_test.php b/tests/classes/lti_flow_test.php
index 32888bb..690d7d8 100644
--- a/tests/classes/lti_flow_test.php
+++ b/tests/classes/lti_flow_test.php
@@ -351,9 +351,7 @@ public function test_init_resource_link(): void {
             $this->cmid,
             $deploymentid,
             $this->user->id,
-            $discussionurl,
-            "",
-            ""
+            $discussionurl
         );
         $this->assertNotNull($message);
 
diff --git a/view.php b/view.php
index 6fa7d63..18deec8 100644
--- a/view.php
+++ b/view.php
@@ -71,8 +71,8 @@
         $moduleinstance->deployment_id,
         $USER->id,
         $moduleinstance->discussion_url,
-        $groupinfo->groupid ?? "",
-        $groupinfo->groupname ?? "",
+        $groupinfo->groupid,
+        $groupinfo->groupname,
     );
 
     $output = $PAGE->get_renderer('mod_kialo');