From fe4406da7d6088fcdbce8e2866e3c7b79a81e347 Mon Sep 17 00:00:00 2001 From: Ram Lavi Date: Wed, 20 Mar 2024 13:48:51 +0200 Subject: [PATCH] checkup: Remove IOThread Policy from VMI In preparation to mounting a configmap to the realtime VMI, removeing the existing IOThread policy, as the former uses a SATA bus [0] and the latter is not supported with SATA devices [0]. [1] https://bugzilla.redhat.com/show_bug.cgi?id=1911590 Signed-off-by: Ram Lavi --- pkg/internal/checkup/checkup.go | 1 - pkg/internal/checkup/vmi/vmi.go | 6 ------ 2 files changed, 7 deletions(-) diff --git a/pkg/internal/checkup/checkup.go b/pkg/internal/checkup/checkup.go index dc56c5a6..434c34ba 100644 --- a/pkg/internal/checkup/checkup.go +++ b/pkg/internal/checkup/checkup.go @@ -249,7 +249,6 @@ func newRealtimeVMI(checkupConfig config.Config) *kvcorev1.VirtualMachineInstanc vmi.WithoutAutoAttachGraphicsDevice(), vmi.WithoutAutoAttachMemBalloon(), vmi.WithAutoAttachSerialConsole(), - vmi.AutoIOThreadPolicy(), vmi.WithZeroTerminationGracePeriodSeconds(), vmi.WithNodeSelector(checkupConfig.VMUnderTestTargetNodeName), vmi.WithContainerDisk(rootDiskName, checkupConfig.VMUnderTestContainerDiskImage), diff --git a/pkg/internal/checkup/vmi/vmi.go b/pkg/internal/checkup/vmi/vmi.go index f794807d..b342f880 100644 --- a/pkg/internal/checkup/vmi/vmi.go +++ b/pkg/internal/checkup/vmi/vmi.go @@ -142,12 +142,6 @@ func WithAutoAttachSerialConsole() Option { } } -func AutoIOThreadPolicy() Option { - return func(vmi *kvcorev1.VirtualMachineInstance) { - vmi.Spec.Domain.IOThreadsPolicy = Pointer(kvcorev1.IOThreadsPolicyAuto) - } -} - func WithVirtIODisk(name string) Option { return func(vmi *kvcorev1.VirtualMachineInstance) { vmi.Spec.Domain.Devices.Disks = append(vmi.Spec.Domain.Devices.Disks, kvcorev1.Disk{