Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error because of dplyr version #189

Open
KatharinaSchmid opened this issue May 15, 2024 · 1 comment
Open

Error because of dplyr version #189

KatharinaSchmid opened this issue May 15, 2024 · 1 comment

Comments

@KatharinaSchmid
Copy link

Hi,

thanks for developing this nice tool. When I upgraded numbat from version 1.2 to 1.4, I first got an error with one of the datasets (see below). I realized that it was related to the dplyr version. I had dplyr 1.1.0 installed first, after updating it vanished. I wanted to report it, so that you can document it in your DESCRIPTION file for the package that a minimum version of dplyr is required now (probably at least 1.1.1?).

Best regards,
Katharina

All cells succeeded
Expanding allelic states..
Error in `inner_join()`:
! `...` must be empty.
✖ Problematic argument:
• relationship = "many-to-many"
Backtrace:
     ▆
  1. ├─numbat::run_numbat(...)
  2. │ └─numbat:::expand_states(exp_post, segs_consensus)
  3. │   └─... %>% ungroup()
  4. ├─dplyr::ungroup(.)
  5. ├─dplyr::mutate(...)
  6. ├─dplyr::rowwise(.)
  7. ├─dplyr::mutate(., seg = paste0(seg, "_", cnv_state), )
  8. ├─dplyr::inner_join(., segs_multi, by = "seg", relationship = "many-to-many")
  9. └─dplyr:::inner_join.data.frame(., segs_multi, by = "seg", relationship = "many-to-many")
 10.   └─rlang::check_dots_empty0(...)
 11.     └─rlang::check_dots_empty(call = call)
 12.       └─rlang:::action_dots(...)
 13.         ├─base (local) try_dots(...)
 14.         └─rlang (local) action(...)
``
teng-gao added a commit that referenced this issue Jun 4, 2024
@teng-gao
Copy link
Collaborator

teng-gao commented Jun 4, 2024

Fixed. Thanks for reporting this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants