keystone-storage-adapter-s3 v1.1.1 depends on unusable version of knox

[augustbjornberg]

Expected behavior

The File model field type, with the keystone-storage-adapter-s3 module is expected to upload files to AWS S3.

Actual/Current behavior

File upload with keystone-storage-adapter-s3 seems to be broken, right now it's throwing the same knox error as i've seen posted by other users for similar errors.

TypeError: mime.lookup is not a function

The runtime crashes and no file is uploaded to S3.

Steps to reproduce the actual/current behavior

Use the File field type with keystone-storage-adapter-s3.

Environment

Software	Version
Keystone	4.0.0-beta.7
Node	8.3.0

[augustbjornberg]

See you later, crocodiles.

[TheModFather]

Resolution can be found @ Automattic/knox#326

[cvn]

This was fixed by PR #4453 and released in 4.0.0-beta.8.

[g3r4n]

@stennie when do you think the next release will be done ? This fix is not in the beta 8

[stennie]

@g3r4n This issue needs to be addressed via the keystone-storage-adapter-s3 dependency.

It was mentioned by @JedWatson on the Keystone Slack earlier today:

@mikehazell has taken a look and, building on keystonejs/keystone-storage-adapter-s3#29, is going to publish a new version that's using the AWS SDK directly instead of knox. It'll be a new major version of that package.

Regards,
Stennie

[g3r4n]

@stennie does this PR is the fix ?

[stennie]

@g3r4n The planned fix is keystonejs/keystone-storage-adapter-s3#35, which will be included in the next release of keystone-storage-adapter-s3.

Regards,
Stennie

[g3r4n]

@stennie thanks for your feedback.

[mikehazell]

FYI - @g3r4n keystonejs/keystone-storage-adapter-s3#35 has been released in v2.0.0.

[g3r4n]

Thanks @mikehazell for your fix !

To everyone don't forget to apply the breaking changes and to generate files name wihout spaces : see this issue

[g3r4n]

Working for me now.
@stennie you can close this issue.

[stennie]

@g3r4n Thanks for confirming the updated s3 adapter worked for you (and reporting the bug generating filenames with spaces).

This issue should remain open until we bump & test the dependency for the next Keystone release.

EDIT: just checked and this isn't an explicit Keystone dependency, so can be closed.

Regards,
Stennie