Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(windows): remove sentry error on firstrun event to update state machine in Idle state #13217

Open
rc-swag opened this issue Feb 13, 2025 · 0 comments
Open

bug(windows): remove sentry error on firstrun event to update state machine in Idle state #13217

rc-swag opened this issue Feb 13, 2025 · 0 comments
Assignees
@rc-swag
Labels
bug windows/
Milestone
B18S2

Comments

@rc-swag
Copy link
Contributor

rc-swag commented Feb 13, 2025 •
edited
Loading

Fixes: KEYMAN-WINDOWS-4W2
Tunnel Vision. It is ok for the very first time keyman setup is run for the firstrun event to occur while the Update State Machine is in the IDLE state. It is only when doing an update that we expect it to be in the usInstalling state.
Stop reporting a sentry error in this scenario.
@rc-swag rc-swag added this to the B18S1 milestone Feb 13, 2025
@rc-swag rc-swag moved this to Todo in Keyman Feb 13, 2025
@darcywong00 darcywong00 modified the milestones: B18S1, B18S2 Feb 15, 2025
rc-swag added a commit that referenced this issue Feb 17, 2025
@rc-swag
fix(windows): remove sentry report on firstrun in idle state
1b72b95 
Remove the error message reporting to sentry if the firstrun
event is recieved in the idle state.

Fixes: #13217
@rc-swag rc-swag mentioned this issue Feb 17, 2025
Closed
rc-swag added a commit that referenced this issue Feb 18, 2025
@rc-swag
fix(windows): remove sentry report on firstrun in idle state
cbf3bd5 
Remove the error message reporting to sentry if the firstrun
event is recieved in the idle state.

Fixes: #13217
@rc-swag rc-swag mentioned this issue Feb 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rc-swag rc-swag

Labels
bug windows/
Projects
Keyman
Status: Todo
Milestone
B18S2
Development

No branches or pull requests
2 participants
@darcywong00 @rc-swag