bug(windows): registry value written two different keys - SRegValue_CheckForUpdates

[rc-swag]

Investigation needs to be done into the SRegValue_CheckForUpdates
When investigating the report usage statistics not being persisted after installation I notice some strange things with the CheckforUpdates registry value.
In the setup executable it is written to SRegKey_KeymanDesktop_CU whereas in Keyman Configuration options it is written to SRegKey_KeymanEngine_CU. It maybe they are intended to be two different things one is checking for updates on install the other is for automatic updates. The one in Keyman Configuration use to say check weekly prior to version 18.0 however it was still then same registry value name but as noted in a different key.

FCheckForUpdates := ValueExists(SRegValue_CheckForUpdates) and ReadBool(SRegValue_CheckForUpdates);

The second thing to notice is that FCheckForUpdates := True; first then
Has this value line FCheckForUpdates := ValueExists(SRegValue_CheckForUpdates) and ReadBool(SRegValue_CheckForUpdates);

If there is no registry value for SRegValue_CheckForUpdates then this will set FCheckForUpdates to False. Meaning the default value is really False. However maybe I am missing someting this all needs further investigation.