Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keylime_agent invalid TOML value #80

Open
koh-osug opened this issue Nov 16, 2023 · 4 comments
Open

keylime_agent invalid TOML value #80

koh-osug opened this issue Nov 16, 2023 · 4 comments
Assignees

Comments

@koh-osug
Copy link

koh-osug commented Nov 16, 2023

Starting the agent results in:

Error: Config(invalid TOML value, did you mean to use a quoted string? at line 2 column 16 in ../etc/keylime/agent.conf.d/bz2114485.conf)
[agent]
tpm_hash_alg = sha256

And also:

Error: Config(invalid TOML value, did you mean to use a quoted string? at line 2 column 10 in ../etc/keylime/agent.conf.d/run_as.conf)
[agent]
run_as = keylime:keylime

--> all must be in quotes

@THS-on
Copy link
Member

THS-on commented Nov 20, 2023

@mpeters can you have a look at it?

It seems like that the migration still is in place for the old Python agent and overrides the rust agent config.

@mpeters mpeters self-assigned this Nov 22, 2023
@mpeters
Copy link
Member

mpeters commented Nov 22, 2023

Yeah, it definitely seems like a bad interaction with the old agent install stuff. I'll take a look at it. Maybe our python installer needs to not install the python agent (by default).

@koh-osug
Copy link
Author

With the new agent and when quoting the values all works smoothly. I had the impression that the new rust agent is already used. What I do rigth now to patch it with my config is:

vagrant ssh -c "sudo -u keylime rm -f /etc/keylime/agent.conf.d/*"
vagrant scp ../keylime-emulator-config/agent.conf /tmp
vagrant ssh -c "sudo mv /tmp/agent.conf /etc/keylime/agent.conf.d/"
vagrant ssh -c "sudo chown -R keylime:keylime /etc/keylime/agent.conf.d/"

I have to do it anyway, since I have to use an external registrar_ip for my tests.

@mpeters
Copy link
Member

mpeters commented Nov 22, 2023

Yes, the latest updates to the vagrant env are using the rust agent. I think there's some interaction with the old python agent install code that updates configs that's messing with the rust agent's configs. I'll dig into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants